-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactoring: boot.exe on windows and cache for installed tools #58
Conversation
9cce993
to
517277b
Compare
src/boot.ts
Outdated
}) | ||
if (utils.isWindows()) { | ||
await exec.exec( | ||
`reg add "HKLM\\SOFTWARE\\JavaSoft\\Java Development Kit\\1.8" /v JAVAHome /d "$env:JAVA_HOME" /f` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hopefully, Java versions can be quite safely extracted from JAVA_HOME
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I count on that as well, but right now I tried to make it work with at least one known JDK without success
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wonder if this can be caused by version mismatch:
This application requires a Java Runtime Environment 1.7.0
^^^^^
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Most likely, this message coming from Launch4j where the minimum JRE is set to 1.7.0, so everything above that should work
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok, it works, but for some reason, the workaround must be a part of the workflow. I'll try it this evening to check what is missing when using exec(...)
inside of the action.
4e0320f
to
4b41749
Compare
4b41749
to
28aba54
Compare
FYI most of pre/post handler usages I've found prefer to use same entrypoint and dispatch based on current stage. The alternative is figuring out how to build 3 different UPD. Though your approach looks also nice, here is my take: https://github.com/zharinov/setup-clojure/blob/test-pre-post/src/entrypoint.ts |
Nice! It looks much better than building separated scripts. I'll give it a try. |
0071fdc
to
57e50d7
Compare
closes #57
closes #6
Added pre and post execution steps to cache installed tools.