Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add deps caching example to README.md #64

Merged
merged 1 commit into from
Aug 12, 2022

Conversation

zharinov
Copy link
Contributor

@zharinov zharinov commented Jul 29, 2022

It would be useful to have a snippet rather than searching it somewhere else

This would be useful to have a snippet rather than searching this somewhere else
~/.gitlibs
~/.deps.clj
# List all files containing dependencies:
key: cljdeps-${{ hashFiles('deps.edn') }}
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've seen variation that use runner.os as the part of key, but seems like it's quite safe to use same cache for all platforms. Maybe I'm wrong, though.

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agree, I don't see the reason to keep runner.os. Let's keep it the way you brought it :) thanks!

@zharinov zharinov changed the title Add caching step sample to README.md Add deps caching example to README.md Jul 29, 2022
Copy link
Owner

@DeLaGuardo DeLaGuardo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wonderful idea! Thanks :)

~/.gitlibs
~/.deps.clj
# List all files containing dependencies:
key: cljdeps-${{ hashFiles('deps.edn') }}
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agree, I don't see the reason to keep runner.os. Let's keep it the way you brought it :) thanks!

@DeLaGuardo DeLaGuardo merged commit 75e4242 into DeLaGuardo:main Aug 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants