Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(snackbars): Add vertical padding for snackBar component #178

Merged
merged 3 commits into from
Jul 10, 2023
Merged

fix(snackbars): Add vertical padding for snackBar component #178

merged 3 commits into from
Jul 10, 2023

Conversation

apauchet
Copy link
Contributor

@apauchet apauchet commented Apr 7, 2023 •
edited by lauthieb
Loading

Changes description

Add vertical padding for snackBar component

Context

Closes #149

Checklist

  • Make sure you are requesting to pull a topic/feature/bugfix branch. Please, don't request directly from your main!
  • Check commits & PR names matches our requested structure. It must follow the https://www.conventionalcommits.org pattern.
  • Check your code additions will fail neither code linting checks.
  • I have reviewed the submitted code.
  • I have tested on a phone device/emulator.
  • I have tested on a tablet device/emulator.
  • I have tested on a large screen device/emulator.
  • If it includes design changes, please ask for a review design-system-core-team-design GitHub team.

Does this introduce a breaking change?

  • No

Screenshots

Phone

Screenshot_20230407_154220

Screenshot_20230407_154314

Tablet

Large screen

Other information

@apauchet apauchet requested review from ManonPolle and a team as code owners April 7, 2023 13:43
@CLAassistant
Copy link

CLAassistant commented Apr 7, 2023 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@dktbitrise
Copy link

You can download the apk here :

sample-debug.apk :
https://app.bitrise.io/app/62ac2962b2dd627a/build/a3553ade-c15f-4980-ac80-e9c84d6859c9/artifact/65f39b681935d021/p/000c4b2321d541ce5463ddd67cab4b1a

@lauthieb lauthieb linked an issue Apr 10, 2023 that may be closed by this pull request
bug: Add vertical padding for Snackbar component #149
Closed
@lauthieb lauthieb added the enhancement 🚀 New feature or request label Apr 20, 2023
@apauchet apauchet force-pushed the fix/snackBar_vertical_padding_component branch from aefee55 to b989cf1 Compare April 21, 2023 15:04
@sonarcloud
Copy link

sonarcloud bot commented Apr 21, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@dktbitrise
Copy link

You can download the apk here :

sample-debug.apk :
https://app.bitrise.io/app/62ac2962b2dd627a/build/cb06f7e4-8578-4205-aeea-9cdb2351b1ec/artifact/53ba74ac7345bdb6/p/89dbc76d706bd064ea0c71b4504c598f

@apauchet apauchet force-pushed the fix/snackBar_vertical_padding_component branch 2 times, most recently from 17c549b to b5b6612 Compare June 16, 2023 13:15
@dktbitrise
Copy link

You can download the apk here :

@ManonPolle ManonPolle force-pushed the fix/snackBar_vertical_padding_component branch from b5b6612 to c3ad194 Compare June 22, 2023 15:00
@dktbitrise
Copy link

You can download the apk here :

sample-debug.apk :
https://app.bitrise.io/app/62ac2962b2dd627a/build/ccba47de-bfcf-4590-b6ca-393adfe4d1b2/artifact/370c8ae43f8adc6c/p/c1fb36b2a6c67b4fe52614e4ec0a130a

@dktbitrise
Copy link

You can download the apk here :

sample-debug.apk :
https://app.bitrise.io/app/62ac2962b2dd627a/build/8449bd54-ad0a-4681-8010-895c02fd44b6/artifact/a7a9826873c8a712/p/a5c4829a8353bd674917a3349001809f

ManonPolle
ManonPolle previously approved these changes Jul 10, 2023
View reviewed changes
@dktbitrise
Copy link

You can download the apk here :

sample-debug.apk :
https://app.bitrise.io/app/62ac2962b2dd627a/build/ac3c630b-1543-4e60-b7a0-09ced31e5888/artifact/3ddf27a139b9c9d5/p/9c48175bcae95a299129f1f0dff4dfa6

@ManonPolle ManonPolle merged commit 006f41d into Decathlon:main Jul 10, 2023
3 checks passed
@sonarcloud
Copy link

sonarcloud bot commented Jul 10, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SimonLeclercq SimonLeclercq SimonLeclercq requested changes

@ManonPolle ManonPolle ManonPolle approved these changes

Assignees

@apauchet apauchet

Labels
enhancement 🚀 New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

bug: Add vertical padding for Snackbar component
6 participants
@apauchet @CLAassistant @dktbitrise @ManonPolle @SimonLeclercq @lauthieb