Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add small tags #182

Merged
merged 4 commits into from
Jul 10, 2023
Merged

feat: add small tags #182

merged 4 commits into from
Jul 10, 2023

Conversation

charlottemougenot
Copy link
Contributor

Changes description

  • Add medium and small tags
  • Generic tags now refers to medium tags
  • Fix typography for medium tags

Context

Closes #151

Checklist

  • Make sure you are requesting to pull a topic/feature/bugfix branch. Please, don't request directly from your main!
  • Check commits & PR names matches our requested structure. It must follow the https://www.conventionalcommits.org pattern.
  • Check your code additions will fail neither code linting checks.
  • I have reviewed the submitted code.
  • I have tested on a phone device/emulator.
  • I have tested on a tablet device/emulator.
  • I have tested on a large screen device/emulator.
  • If it includes design changes, please ask for a review design-system-core-team-design GitHub team.

Does this introduce a breaking change?

  • No

Screenshots

Phone

Screenshot_1681995192

Tablet

Screenshot_1681994994

Large screen

Screenshot_1681995241

Other information

@charlottemougenot charlottemougenot requested a review from a team April 20, 2023 12:57
@dktbitrise
Copy link

You can download the apk here :

sample-debug.apk :
https://app.bitrise.io/app/62ac2962b2dd627a/build/abab5d59-6c16-4ba7-8413-857015f12277/artifact/2fe94ab2352dbbf4/p/cc7d7f41375ea80734e362bcaf877e6e

@lauthieb lauthieb added the enhancement 🚀 New feature or request label Apr 20, 2023
@dktbitrise
Copy link

You can download the apk here :

sample-debug.apk :
https://app.bitrise.io/app/62ac2962b2dd627a/build/126a831e-8a02-40ed-885c-bf9ef7602a11/artifact/315354d0ca161723/p/4371d83019c8a8203373c9247ea18175

@sonarcloud
Copy link

sonarcloud bot commented May 4, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@dktbitrise
Copy link

You can download the apk here :

sample-debug.apk :
https://app.bitrise.io/app/62ac2962b2dd627a/build/fbb655cd-bb8a-4bba-ad65-6b6d91f7f9df/artifact/4371e5d171c97050/p/97a040cabf7853de87d6f933e7b9527d

@ManonPolle ManonPolle merged commit 46a3b9f into Decathlon:main Jul 10, 2023
3 checks passed
@sonarcloud
Copy link

sonarcloud bot commented Jul 10, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ManonPolle ManonPolle ManonPolle approved these changes

Assignees

@charlottemougenot charlottemougenot

Labels
enhancement 🚀 New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

feat(tag): Add a small size for Tag component
4 participants
@charlottemougenot @dktbitrise @ManonPolle @lauthieb