Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimizer readme #680

Merged
merged 16 commits into from
Feb 7, 2023
Merged

Optimizer readme #680

merged 16 commits into from
Feb 7, 2023

Conversation

Louis-Dupont
Copy link
Contributor

@Louis-Dupont Louis-Dupont commented Feb 1, 2023

The requirements were as follows:

  • SG Optimizers
  • How to use PyTorch native optimizers
  • How to use your own optimizers (including in a recipe)

Concerning "How to use your own optimizers": we currently don't support it because the only way to use an optimizer is to pass it as a string, and we don't have a registry for optimizers. Do we want to add this registry ?
Besides this, I don't see what else to show in this notebook, if you have an idea.

@dagshub
Copy link

dagshub bot commented Feb 1, 2023

@Louis-Dupont Louis-Dupont marked this pull request as ready for review February 2, 2023 08:26
Copy link
Collaborator

@shaydeci shaydeci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, I think you are on a good point here - we do need to add registry for optimisers.
Lets add it and update how one can use their own optimiser like you suggested.

Copy link
Collaborator

@ofrimasad ofrimasad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we do have a register_optimizer function now. so you can add this as well

documentation/source/optimizers.md Outdated Show resolved Hide resolved
Copy link
Collaborator

@shaydeci shaydeci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also another very important point:

We need to add docs for initialise_param_groups and update_param_groups, and demonstrate how it interacts with the optimiser. Thats the only way now we have in SG to support different configurations among different the different network parameters.

shaydeci and others added 4 commits February 5, 2023 15:28
* first draft

* comments

* example added at top

* warning about ddp samplers moved to subsection

* comments resolved

* grammar

* re-phrase modules import explanation

---------

Co-authored-by: Ofri Masad <ofrimasad@users.noreply.github.com>
@Louis-Dupont
Copy link
Contributor Author

Also another very important point:

We need to add docs for initialise_param_groups and update_param_groups, and demonstrate how it interacts with the optimiser. Thats the only way now we have in SG to support different configurations among different the different network parameters.

I added a section, do you think its enough?

Copy link
Collaborator

@ofrimasad ofrimasad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks very nice.
I think there is a minor issue in the code

documentation/source/optimizers.md Show resolved Hide resolved
documentation/source/optimizers.md Outdated Show resolved Hide resolved
Copy link
Collaborator

@ofrimasad ofrimasad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Louis-Dupont Louis-Dupont merged commit 1d2a8fe into master Feb 7, 2023
@Louis-Dupont Louis-Dupont deleted the feature/SG-605-add_optimizers_tuto branch February 7, 2023 07:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants