Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid conflict when diagnosing expand_design() object #238

Merged
merged 3 commits into from Mar 20, 2019
Merged

Avoid conflict when diagnosing expand_design() object #238

merged 3 commits into from Mar 20, 2019

Conversation

clarabicalho
Copy link
Contributor

  • Changes multi-arm estimator column label from "N" to "N_DIM."
  • Includes test to avoid conflicting label columns in expanded design diagnosis. More specifically, it checks that no column names in estimate data frame are the same as designer arguments (this would generate errors in DDWizard when it calls diagnose_design() on an object returned by expand_design()).

@clarabicalho
Change multi_arm estimator data frame term
6986445 
Change term name in estimator data.frame to avoid conflicts when using `diagnose_designs(expand_design())` with `multi_arm_designer()`.

See DeclareDesign/DeclareDesign#402
@clarabicalho
Include test to avoid error in DDWizard
5dbd383 
This tests that estimates data.frame does not return same name column as any of the parameters of a designer.

See DeclareDesign/DeclareDesign#402.
@clarabicalho
More specific test description
0a262f5
@coveralls
Copy link

Pull Request Test Coverage Report for Build 1365

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.0001%) to 99.889%
Totals Coverage Status
Change from base Build 1359: 0.0001%
Covered Lines: 897
Relevant Lines: 898
💛 - Coveralls

@jaspercooper
Copy link
Contributor

LGTM, thanks!

@jaspercooper jaspercooper merged commit b476aaa into master Mar 20, 2019
@jaspercooper jaspercooper deleted the expand_design_conflict branch March 20, 2019 18:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jaspercooper jaspercooper Awaiting requested review from jaspercooper

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@clarabicalho @coveralls @jaspercooper