Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid conflict when diagnosing expand_design() object #238

Merged
merged 3 commits into from Mar 20, 2019
Merged

Avoid conflict when diagnosing expand_design() object #238

merged 3 commits into from Mar 20, 2019

Commits on Mar 18, 2019

  1. Change multi_arm estimator data frame term 

    Change term name in estimator data.frame to avoid conflicts when using `diagnose_designs(expand_design())` with `multi_arm_designer()`.

See DeclareDesign/DeclareDesign#402
    @clarabicalho
    clarabicalho committed Mar 18, 2019
    Copy the full SHA
    6986445 View commit details
    Browse the repository at this point in the history

  2. Include test to avoid error in DDWizard 

    This tests that estimates data.frame does not return same name column as any of the parameters of a designer.

See DeclareDesign/DeclareDesign#402.
    @clarabicalho
    clarabicalho committed Mar 18, 2019
    Copy the full SHA
    5dbd383 View commit details
    Browse the repository at this point in the history

  3. More specific test description

    @clarabicalho
    clarabicalho committed Mar 18, 2019
    Copy the full SHA
    0a262f5 View commit details
    Browse the repository at this point in the history