Apply substitutions to source #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
_(Note: I somehow got this fix on the wrong repo at first; see Deep-Symmetry/bytefield-svg#27. _**Here**_ is where I actually intended it—but they apparently both need it.)_ I ran into this in a document with a _*bunch*_ of `bytefield` displays, where I wanted/needed to reduce the duplication of the same `(defattrs ...)` over and over again. By using: ``` :bytefieldDefaults: (defattrs :plain {:font-family "inherit" :font-size 14}) [bytefield,subs=normal] ---- {bytefieldDefaults} (draw-column-headers) (draw-box "foo") (draw-column-bottom) ---- ``` I expected to be able to inject some common defaults. Instead, I got a "Could not resolve symbol: normal [at line 1, column 1]" error. Digging into the code, I found that the `extension.js` line 15 was using `attrs.subs` as the "source" argument to `$apply_subs()`, rather than passing the original source. Using `source` here seems to fix things.
|
Thanks again for finding and fixing this! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(Note: I somehow got this fix on the wrong repo at first; see Deep-Symmetry/bytefield-svg#27. Here is where I actually intended it—but they apparently both need it.)
I ran into this in a document with a bunch of
bytefielddisplays, where I wanted/needed to reduce the duplication of the same(defattrs ...)over and over again. By using:I expected to be able to inject some common defaults. Instead, I got a "Could not resolve symbol: normal [at line 1, column 1]" error.
Digging into the code, I found that the
extension.jsline 15 was usingattrs.subsas the "source" argument to$apply_subs(), rather than passing the original source. Usingsourcehere seems to fix things.