Integrate model reference in mock table #5
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The current API is still a bit verbose and unclear, for example:
from_inputs
. The feels seems a bit unclear (i.e. what is "inputs")?.data
as list of dicts. However, there is also afrom_inputs
method. It can become unclear to the user what happens whenWhat changed
table_meta
decorator that can be used to pass MockTable metadata (at the moment onlytable_ref
- we will be able to reuse this in the future for other metadata). This way, we can leave the class attribute definition to only column typesfrom_inputs
tofrom_mocks
from_dicts
that should make more clear what happens compared to the newfrom_mocks
method