Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix PSSM checks #424

Closed
2 tasks done
gcroci2 opened this issue May 15, 2023 · 1 comment · Fixed by #425
Closed
2 tasks done

Fix PSSM checks #424

gcroci2 opened this issue May 15, 2023 · 1 comment · Fixed by #425

Comments

@gcroci2
Copy link
Collaborator

gcroci2 commented May 15, 2023

There are few issues related to PR #401; in cases in which amino acids in pssm files do not match pdb file:

  • Output a less verbose message for each
  • Only check pssms if relevant feature module is selected. Even if I'm selecting 'components' and 'contact' modules features it's checking the PSSM, which should not happen I think (I'm not selecting the module for the PSSM which is 'conservation').
@gcroci2 gcroci2 created this issue from a note in Generalization - Task 1 (To do) May 15, 2023
@DaniBodor
Copy link
Collaborator

On second thought, I disagree with task 1 here. I think if task 3 is fixed, then the error should remain and hdf5 files shouldn't be created. Otherwise the danger is that users will not notice the warnings and create faulty hdf5 files and use them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Development

Successfully merging a pull request may close this issue.

2 participants