New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: check PSSMs #401
fix: check PSSMs #401
Conversation
This PR is stale because it has been open for 14 days with no activity. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice checks :-)
I'd avoid adding exclude_feature_module
(the least parameters the better), and I'd implement the solution we were discussing, which is defaulting the modules to the essentials and making feature_modules
required. I don't think opening a new PR for this is needed, right?
@@ -60,7 +60,7 @@ runs: | |||
# Only way to install msms is through conda | |||
conda install -c bioconda msms | |||
# Safest way to install PyTorch and PyTorch Geometric is through conda | |||
conda install pytorch torchvision torchaudio cpuonly -c pytorch | |||
conda install pytorch torchvision torchaudio cpuonly -c pytorch==2.0.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great! I've also just noticed that in one of my branches. Also I had a question: why is the line 66 needed? (# Install optional pyg dependencies) Shouldn't conda install pyg -c pyg
take care of the pyg dependencies?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't know why, but it doesn't. I guess because they are optional?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
With conda, from their website it should not be necessary. Only with pip. So if it doesn't work using only conda install pyg -c pyg
their docs are wrong
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added comments about minor edits in the process
method. I think that explicitly defaulting the modules (not using None) and allowing for 'all' but not None is clear from the user perspective.
Agreed! |
Summary:
test_incorrect_pssm_order
) and missing entries (test_incomplete_pssm
) in pssm in test_query.pyquery.process
to onlycomponents
andcontact
Note: It would be nice if there were some form of documentation on what the pssm files should look like and/or where and how to build it correctly, as it is very easy get it wrong and very difficult to diagnose or even detect if it is. This is not implemented in this PR.