Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: move preprocess function to QueryDataset class and rename #252

Merged

Conversation

gcroci2
Copy link
Collaborator

@gcroci2 gcroci2 commented Nov 22, 2022

Instead of populating a list with queries from the API, we use the former QueryDataset class (now QueryCollection class), which has a built-in method to append elements to the queries list (add method), and in which queries is defined as a property method of QueryCollection itself. A much cleaner way of doing the same thing.

Then I moved the former preprocess function (now process) to QueryCollection class as a method.

@gcroci2 gcroci2 linked an issue Nov 22, 2022 that may be closed by this pull request
@gcroci2 gcroci2 merged commit db0f113 into gcroci2_181_preprocess_one_file Nov 23, 2022
@gcroci2 gcroci2 deleted the gcroci2_231_reorganize_preprocess_func branch November 23, 2022 11:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Reorganize preprocess function/module
2 participants