Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: fix conflicts in package #386

Merged
merged 4 commits into from Mar 16, 2023
Merged

build: fix conflicts in package #386

merged 4 commits into from Mar 16, 2023

Conversation

DaniBodor
Copy link
Collaborator

@DaniBodor DaniBodor commented Mar 16, 2023

pytorch geometric does not (yet?) work with last night's released pytorch 2.0.

@gcroci2 , is the readme like this correct for the GPU version as well or should pytorch-cuda version also be updated? And is the conventional commit type correct?

@DaniBodor DaniBodor changed the title freeze pytorch geometric version fix conflicts in package Mar 16, 2023
@DaniBodor DaniBodor changed the title fix conflicts in package build: fix conflicts in package Mar 16, 2023
@DaniBodor DaniBodor requested a review from gcroci2 March 16, 2023 16:55
README.md Outdated Show resolved Hide resolved
Copy link
Collaborator

@gcroci2 gcroci2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor typo, all good! I checked the docs and the instructions for cuda 11.7 are fine as well :)

Co-authored-by: Giulia Crocioni <55382553+gcroci2@users.noreply.github.com>
@DaniBodor DaniBodor merged commit fdc66c8 into main Mar 16, 2023
5 checks passed
@DaniBodor DaniBodor deleted the freeze_pyg_version branch March 16, 2023 19:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants