Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: make feature modules and tests uniform and ditch duplicate code #400

Merged
merged 30 commits into from Mar 21, 2023

Conversation

DaniBodor
Copy link
Collaborator

@DaniBodor DaniBodor commented Mar 20, 2023

After looking at the different features and their tests a lot recently, i got really annoyed about them all being formatted different while doing the same thing. So decided to make it nice instead

@DaniBodor DaniBodor marked this pull request as ready for review March 20, 2023 22:40
@DaniBodor DaniBodor requested a review from gcroci2 March 21, 2023 00:20
Copy link
Collaborator

@gcroci2 gcroci2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Much more in order now <3

@DaniBodor DaniBodor merged commit 17019d6 into main Mar 21, 2023
5 checks passed
@DaniBodor DaniBodor deleted the uniform_features_modules_dbodor branch March 21, 2023 11:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants