Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add linter to CI to ensure PEP8 improvement before merge #10

Closed
mathpluscode opened this issue Jun 13, 2020 · 2 comments · Fixed by #73
Closed

Add linter to CI to ensure PEP8 improvement before merge #10

mathpluscode opened this issue Jun 13, 2020 · 2 comments · Fixed by #73
Assignees
@NMontanaBrown

Comments

@mathpluscode
Copy link
Member

We can add a pre-commit check which verifies the code format before committing.
@NMontanaBrown
Copy link
Member

  • Add linter to CI to ensure code linted to Pep8 before merge during PR.

@NMontanaBrown NMontanaBrown changed the title Add formatter and pre-commit Add linter to CI to ensure PEP8 improvement before merge Jun 16, 2020
@NMontanaBrown NMontanaBrown mentioned this issue Jun 19, 2020
Closed
@NMontanaBrown
Copy link
Member

See: https://github.com/Project-MONAI/MONAI/blob/master/CONTRIBUTING.md#automatic-code-formatting
and
https://github.com/psf/black#installation-and-usage
Thanks for the suggestion @tvercaut!

@NMontanaBrown NMontanaBrown mentioned this issue Jun 20, 2020
Closed
2 tasks
mathpluscode added a commit that referenced this issue Jun 25, 2020
@mathpluscode
issue #10 add pre comit
3276db2
@mathpluscode mathpluscode mentioned this issue Jun 25, 2020
Merged
6 tasks
mathpluscode added a commit that referenced this issue Jun 25, 2020
@mathpluscode
issue #10 update setup
09f640e
mathpluscode added a commit that referenced this issue Jun 25, 2020
@mathpluscode
issue #10 format file
8f27f34
mathpluscode added a commit that referenced this issue Jun 25, 2020
@mathpluscode
issue #10 update ci
db8d057
mathpluscode added a commit that referenced this issue Jun 25, 2020
@mathpluscode
issue #10 fix typo
c8a00a3
NMontanaBrown added a commit that referenced this issue Jun 26, 2020
@NMontanaBrown
Issue #10: added pylint as a git hook to the pre-commit config such t…
66cef6f 
…hat specific errors not covered by flake and black are returned before committing
mathpluscode added a commit that referenced this issue Jun 27, 2020
@mathpluscode
issue #10 comment out pylint temporarily
3d18d4b
mathpluscode added a commit that referenced this issue Jun 27, 2020
@mathpluscode
issue #10 update readme
b055f3b
mathpluscode added a commit that referenced this issue Jun 27, 2020
@mathpluscode
issue #10 move pre-commit
2b2ef15
mathpluscode added a commit that referenced this issue Jun 27, 2020
@mathpluscode
issue #10 add more pre commit hooks
e249099
mathpluscode added a commit that referenced this issue Jun 27, 2020
@mathpluscode
issue #10 fix black isort conflict, max len = 88
ce0266c
mathpluscode added a commit that referenced this issue Jun 27, 2020
@mathpluscode
issue #10 black change to line len 88
8497d3c
s-sd pushed a commit that referenced this issue Jul 2, 2020
@mathpluscode
issue #10 add pre comit
a685ea6
s-sd pushed a commit that referenced this issue Jul 2, 2020
@mathpluscode
issue #10 update setup
38c75c9
s-sd pushed a commit that referenced this issue Jul 2, 2020
@mathpluscode
issue #10 format file
4b71cf0
s-sd pushed a commit that referenced this issue Jul 2, 2020
@mathpluscode
issue #10 update ci
6de3a86
s-sd pushed a commit that referenced this issue Jul 2, 2020
@mathpluscode
issue #10 fix typo
df29a9e
s-sd pushed a commit that referenced this issue Jul 2, 2020
@NMontanaBrown
Issue #10: added pylint as a git hook to the pre-commit config such t…
f33386f 
…hat specific errors not covered by flake and black are returned before committing
s-sd pushed a commit that referenced this issue Jul 2, 2020
@mathpluscode
issue #10 comment out pylint temporarily
bbf4466
s-sd pushed a commit that referenced this issue Jul 2, 2020
@mathpluscode
issue #10 update readme
a9198a2
s-sd pushed a commit that referenced this issue Jul 2, 2020
@mathpluscode
issue #10 move pre-commit
4aa495a
s-sd pushed a commit that referenced this issue Jul 2, 2020
@mathpluscode
issue #10 add more pre commit hooks
dd1523e
s-sd pushed a commit that referenced this issue Jul 2, 2020
@mathpluscode
issue #10 fix black isort conflict, max len = 88
ed2798d
s-sd pushed a commit that referenced this issue Jul 2, 2020
@mathpluscode
issue #10 black change to line len 88
aaa1f2c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@NMontanaBrown NMontanaBrown

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

10 precommit DeepRegNet/DeepReg
2 participants
@mathpluscode @NMontanaBrown