Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add Probely to the list of integrations. #103

Merged
merged 5 commits into from
Jul 23, 2020

Conversation

tmendo
Copy link
Contributor

@tmendo tmendo commented Jun 22, 2020

adds Probely to the list of integrations.

@tmendo
Copy link
Contributor Author

tmendo commented Jul 2, 2020

friendly ping @valentijnscholten @madchap :)

@valentijnscholten
Copy link
Member

This sounds pretty cool, I think Probely is the first integration doing it like this. Is it using import underneath? and also re_import, of just import? Might be good to indicate what kind of permissions the user needs that the API key belongs to.
Would it be beneficials to add something in the docs to say Probely integration has been tested with APIv2 for Defect Dojo 1.5.x-1.6.x or something? Backwards incompatible changes are rare, but may happen.

add a requirement for the Probely integration: user needs to be staff
@tmendo
Copy link
Contributor Author

tmendo commented Jul 21, 2020

friendly reminder to @madchap :)

docs/integrations.rst Outdated Show resolved Hide resolved
Copy link
Collaborator

@madchap madchap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove the naked probely.com link.

remove the Probely link
@tmendo tmendo requested a review from madchap July 23, 2020 09:18
@valentijnscholten valentijnscholten merged commit 7b900bc into DefectDojo:master Jul 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants