Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Twistlock parser fix for riskFactors + cve field #1123

Merged
merged 2 commits into from May 14, 2019
Merged

Twistlock parser fix for riskFactors + cve field #1123

merged 2 commits into from May 14, 2019

Conversation

madchap
Copy link
Collaborator

@madchap madchap commented May 10, 2019

Got bitten by it today. This fixes it.

Please submit your pull requests to the 'dev' branch.

When submitting a pull request, please make sure you have completed the following checklist:

  • Your code is flake8 compliant (DefectDojo's code isn't currently flake8 compliant, but we're trying to correct that.)
  • If this is a new feature and not a bug fix, you've included the proper documentation in the ReadTheDocs documentation folder. https://github.com/DefectDojo/Documentation/tree/master/docs or provide feature documentation in the PR.
  • Model changes should include the necessary migrations in the dojo/dd_migrations folder.
  • Add applicable tests to the unit tests.

@madchap
Copy link
Collaborator Author

madchap commented May 10, 2019

This PR supercedes #1117 (includes the cve too).

cc @dr3dd589 can you then maybe close your PR?

@madchap madchap changed the title Twistlock parser fix for riskFactors Twistlock parser fix for riskFactors + cve field May 10, 2019
@valentijnscholten
Copy link
Member

If the risk factors are not present in the import, does it mean there are no risk factors. Or does it mean there are no risk factors specified. Might sound like nitpicking, but just check to see if we want to change the default text to "No risk factors specified' :-)

@madchap
Copy link
Collaborator Author

madchap commented May 10, 2019

@valentijnscholten good point. I'll keep that in mind when looking at these reports in the near future and amend as necessary 👍 (it should not block the merge though! ;-))

@devGregA devGregA merged commit 7b2d680 into DefectDojo:dev May 14, 2019
@aaronweaver aaronweaver mentioned this pull request Jun 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants