Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Twistlock parser fix for riskFactors + cve field #1123

Merged
merged 2 commits into from May 14, 2019
Merged

Twistlock parser fix for riskFactors + cve field #1123

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
132f233
It happens the riskFactors key is not there at all. Got bitten by it
madchap May 10, 2019
865801c
Add cve field as well.
madchap May 10, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 3 additions & 1 deletion dojo/tools/twistlock/parser.py
View file
Open in desktop
Expand Up @@ -54,10 +54,12 @@ def get_item(vulnerability, test):
vector = vulnerability['vector'] if 'vector' in vulnerability else "CVSS vector not provided. "
status = vulnerability['status'] if 'status' in vulnerability else "There seems to be no fix yet. Please check description field."
cvss = vulnerability['cvss'] if 'cvss' in vulnerability else "No CVSS score yet."
riskFactors = vulnerability['riskFactors'] if 'riskFactors' in vulnerability else "No risk factors."

# create the finding object
finding = Finding(
title=vulnerability['id'] + ": " + vulnerability['packageName'] + " - " + vulnerability['packageVersion'],
cve=vulnerability['id'],
test=test,
severity=severity,
description=vulnerability['description'] + "<p> Vulnerable Package: " +
Expand All @@ -71,7 +73,7 @@ def get_item(vulnerability, test):
duplicate=False,
out_of_scope=False,
mitigated=None,
severity_justification="{}({})\n\n{}".format(vector, cvss, vulnerability['riskFactors']),
severity_justification="{}({})\n\n{}".format(vector, cvss, riskFactors),
impact=severity)

finding.description = finding.description.strip()
Expand Down