Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RENAMED: Finding.is_Mitigated to is_mitigated #3854

Merged
merged 4 commits into from
May 1, 2021
Merged

RENAMED: Finding.is_Mitigated to is_mitigated #3854

merged 4 commits into from
May 1, 2021

Conversation

valentijnscholten
Copy link
Member

came across this annoying typo and decided to fix it.
let me know what you think, might be nitpicking, might be good for readability!

@valentijnscholten valentijnscholten added maintenance New Migration Adding a new migration file. Take care when merging. easy-review labels Feb 12, 2021
@macedogm macedogm mentioned this pull request Feb 14, 2021
Merged
@madchap
Copy link
Collaborator

madchap commented Feb 14, 2021

This would probably need a heads-up in the release notes. I - for one - am going to be impacted with regards to scripts outside of DefectDojo.

@madchap
Copy link
Collaborator

madchap commented Feb 14, 2021 •
edited
Loading

Adding the Breaking Changes label so that it shows up at the top of the release notes. It's bending the label's arm a bit, dunno. Better suggestion?

@valentijnscholten
Copy link
Member Author

hmm thought might not be too big an issue for the API, but maybe we should do this in v2.0 where some other breaking changes might take place?

@valentijnscholten valentijnscholten changed the title rename is_Mitigated to is_mitigated cleanup: rename is_Mitigated to is_mitigated Feb 14, 2021
@valentijnscholten valentijnscholten added this to the 2.0.0 milestone Feb 14, 2021
@github-actions
Copy link
Contributor

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions
Copy link
Contributor

Conflicts have been resolved. A maintainer will review the pull request shortly.

@madchap madchap self-requested a review February 14, 2021 22:48
@madchap
Copy link
Collaborator

madchap commented Feb 14, 2021

Removing my approval for now to avoid a too quick merge. Let's take it on slack?

@github-actions
Copy link
Contributor

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@madchap
Copy link
Collaborator

madchap commented Mar 4, 2021

Sounds like this one will need to make it in sooner to avoid potential future headaches...

@valentijnscholten valentijnscholten changed the title cleanup: rename is_Mitigated to is_mitigated cleanup 2.0: rename is_Mitigated to is_mitigated Apr 26, 2021
@valentijnscholten valentijnscholten changed the title cleanup 2.0: rename is_Mitigated to is_mitigated RENAMED: Finding.is_Mitigated to is_mitigated May 1, 2021
@github-actions
Copy link
Contributor

github-actions bot commented May 1, 2021

Conflicts have been resolved. A maintainer will review the pull request shortly.

@valentijnscholten valentijnscholten merged commit 3ba082f into DefectDojo:dev May 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@damiencarol damiencarol damiencarol approved these changes

@madchap madchap Awaiting requested review from madchap

Assignees
No one assigned
Labels
Breaking Changes maintenance New Migration Adding a new migration file. Take care when merging.
Projects
None yet
Milestone
2.0.0
Development

Successfully merging this pull request may close these issues.
3 participants
@valentijnscholten @madchap @damiencarol