Minor improvements to SpotBugs and Dependency Check parsers #4249
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The report contains some HTML code into it that was not being proper parsed. Now, using BeautifulSoup, we can work with tags and deliver a more precise report. Enhancements: - Handles leading blankspaces, multiple breaklines, bold text and inline/multiline code. - A more clear description. - References moved to where they belong with links that work.
|
Thanks. Are there any unit tests / samples you could add that "prove" the new html parsing part is working correctly? |
damiencarol
suggested changes
Apr 10, 2021
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
|
Conflicts have been resolved. A maintainer will review the pull request shortly. |
|
I'm not sure if these unittests for the HTML parsing are good enough. Let me know what you guys think ;) |
valentijnscholten
suggested changes
May 15, 2021
No need for them to be there (it was actually adding more breaklines for some reason).
adiffpirate
force-pushed
the
minor-improvement-parsers
branch
from
dbaa441
to
bc34fee
Compare
valentijnscholten
approved these changes
May 16, 2021
adiffpirate
force-pushed
the
minor-improvement-parsers
branch
from
41f90dd
to
bb2e4c2
Compare
damiencarol
approved these changes
Jun 16, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SpotBugs
The report contains some HTML code that was not being properly parsed.
Now, using BeautifulSoup, we can work with tags and deliver a more precise report.
Enhancements:
Dependency Check