Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow alternate service types without enabling gke #4388

Closed
wants to merge 13 commits into from
Closed

Allow alternate service types without enabling gke #4388

wants to merge 13 commits into from

Conversation

joesteffee
Copy link
Contributor

@joesteffee joesteffee commented Apr 28, 2021 •
edited
Loading

Deploying in EKS with an ALB ingress requires either type=LoadBalancer or type=NodePort. The only way to enable NodePort today is by enabling GKE which enables some other stuff we don't want. This allows the user to set a custom service type

Enable use of custom paths for ingress (alb ingress controller requires /* instead of /)

@madchap
Copy link
Contributor

madchap commented Apr 30, 2021

@joesteffee can you please fix the linting? Cheers.

@madchap
Copy link
Contributor

madchap commented Apr 30, 2021

Also, please rebase onto dev, not master, as indicated in the PR template. Cheers.

madchap
madchap suggested changes Apr 30, 2021
View reviewed changes
Copy link
Contributor

@madchap madchap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See above comments.

@joesteffee joesteffee changed the base branch from master to dev April 30, 2021 16:23
@joesteffee joesteffee closed this Apr 30, 2021
valentijnscholten added a commit that referenced this pull request May 23, 2021
@joesteffee @valentijnscholten
Allow alternate service types without enabling gke #4388 (#4410)
dcc5a7b 
* wip

* bump version

* Update benchmark_requirement.json

* bump chart version

* Update Chart.yaml

Co-authored-by: Joe Steffee <jsteffee@flexera.com>
Co-authored-by: valentijnscholten <valentijnscholten@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@madchap madchap madchap requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@joesteffee @madchap @valentijnscholten