Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

REMOVE: Engagement_Type model #4421

Merged

Conversation

valentijnscholten
Copy link
Member

fixes #3728

eng_type foreign key field for Engagement was replaced in the past by a CharField called engagement_type field

@valentijnscholten valentijnscholten added maintenance New Migration Adding a new migration file. Take care when merging. labels May 2, 2021
@valentijnscholten valentijnscholten added this to the 2.0.0 milestone May 2, 2021
@github-actions
Copy link
Contributor

github-actions bot commented May 2, 2021

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions
Copy link
Contributor

github-actions bot commented May 2, 2021

Conflicts have been resolved. A maintainer will review the pull request shortly.

Copy link
Collaborator

@madchap madchap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't forget to update the migration dep and filename.

@github-actions
Copy link
Contributor

github-actions bot commented May 2, 2021

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions
Copy link
Contributor

github-actions bot commented May 3, 2021

Conflicts have been resolved. A maintainer will review the pull request shortly.

@valentijnscholten
Copy link
Member Author

missed the outdated migration name in #4264. fixed that here and going to merge with 1 approval to fix dev.

@valentijnscholten valentijnscholten merged commit 10dd421 into DefectDojo:dev May 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cleanup maintenance New Migration Adding a new migration file. Take care when merging.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants