Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add new parser - Mobsfscan #4845

Merged
merged 4 commits into from Jul 29, 2021
Merged

add new parser - Mobsfscan #4845

merged 4 commits into from Jul 29, 2021

Conversation

ansidorov
Copy link
Contributor

mobsfscan is a static analysis tool that can find insecure code patterns in your Android and iOS source code. Supports Java, Kotlin, Swift, and Objective C Code.

It could be found at: https://github.com/MobSF/mobsfscan

Copy link
Contributor

@Maffooch Maffooch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ansidorov
Copy link
Contributor Author

Is this different from

https://github.com/DefectDojo/django-DefectDojo/tree/master/dojo/tools/mobsf

Yes, mobsf (https://github.com/MobSF/Mobile-Security-Framework-MobSF) more complex tool with different features.

Copy link
Contributor

@Maffooch Maffooch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@damiencarol this one looks good to me, do you agree?

@Maffooch Maffooch dismissed their stale review July 20, 2021 20:47

New parser is different from existing

@damiencarol
Copy link
Contributor

@Maffooch wait, I want to confirm that it's the new scanner of MOBSF

Copy link
Contributor

@damiencarol damiencarol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Want to take time to review this one

@damiencarol
Copy link
Contributor

@ansidorov found a minor thing.

@ansidorov
Copy link
Contributor Author

@ansidorov found a minor thing.

Fixed

@damiencarol
Copy link
Contributor

@damiencarol this one looks good to me, do you agree?

Yes, made a minor comment but it's ok for me.

@Maffooch Maffooch merged commit 9421e58 into DefectDojo:dev Jul 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants