Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Endpoint clean in migration #4887

Merged
merged 2 commits into from
Aug 6, 2021
Merged

Fix Endpoint clean in migration #4887

merged 2 commits into from
Aug 6, 2021

Conversation

kiblik
Copy link
Contributor

@kiblik kiblik commented Jul 28, 2021 •
edited
Loading

@kiblik kiblik mentioned this pull request Jul 28, 2021
Closed
3 tasks
@Maffooch
Copy link
Contributor

I think a better solution would be to add a note in the upgrade docs to run the endpoint migration script rather then making a duplicate migration.

@zakrush
Copy link
Contributor

zakrush commented Aug 5, 2021

@Maffooch In my case endpoint migration didn't help me when I upgraded to 2.0.3.

@kiblik
Copy link
Contributor Author

kiblik commented Aug 5, 2021 •
edited
Loading

@zakrush, @Maffooch was referring to migration which I wrote as part of this PR

@Maffooch, I removed migration and added description to documentation

Maffooch
Maffooch approved these changes Aug 5, 2021
View reviewed changes
Copy link
Contributor

@Maffooch Maffooch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@zakrush correct. There was a bug in the endpoint migration fix. This PR corrects the bug.

@valentijnscholten valentijnscholten merged commit d20f4ab into DefectDojo:dev Aug 6, 2021
@kiblik kiblik deleted the endpoint_fix_clean branch August 18, 2021 21:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@valentijnscholten valentijnscholten valentijnscholten approved these changes

@Maffooch Maffooch Maffooch approved these changes

Assignees
No one assigned
Labels
bugfix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@kiblik @Maffooch @zakrush @valentijnscholten @damiencarol