Remove deprecated fields of Findings #5261
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
New Migration
StefanFl
force-pushed
the
finding_deprecated_fields
branch
from
ff73e00
to
971c669
Compare
valentijnscholten
approved these changes
Oct 9, 2021
damiencarol
approved these changes
Oct 12, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
line_number,sourcefileandsourcefilepathare redundant fields and are only written by 3 parsers (Fortify, GitLab SAST and Veracode). These 3 parsers writelineandfile_pathas well, so the redundant fields can be removed without migration of data.is_templateis a remains of the time beforeFinding_Templatewas implemented in 2015. It could be set when adding or editing a finding, then a template is saved additionally to the actual findingand the flag is set toFalse. The same can be achieved with the action menu while viewing a finding or from the findings list, sois_templatecan be removed without data migration as well.