Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Engagement - Unified lists and CSV/Excel export #5266

Merged
merged 3 commits into from
Oct 22, 2021
Merged

Engagement - Unified lists and CSV/Excel export #5266

merged 3 commits into from
Oct 22, 2021

Conversation

StefanFl
Copy link
Contributor

This PR contains 2 changes about engagements:

  • The lists for active engagements and all engagements are the same now. They contain the status attribute and can be sorted by start date:
    2021-10-10 11_16_28-Active Engagements _ DefectDojo
    The previous All engagements list is still available in the menu as Engagements by Product:
    2021-10-10 11_16_01-Active Engagements _ DefectDojo
  • The Active Engagements and All Engagements lists can now export the engagements as CSV and Excel files.

accesslint[bot]
accesslint bot suggested changes Oct 10, 2021
View reviewed changes
Copy link

@accesslint accesslint bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are accessibility issues in these changes.

dojo/templates/dojo/engagement.html Show resolved Hide resolved
@StefanFl
Copy link
Contributor Author

fixes #5253

accesslint[bot]
accesslint bot approved these changes Oct 10, 2021
View reviewed changes
Copy link

@accesslint accesslint bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏 You fixed the issue(s)! Great work.

@valentijnscholten valentijnscholten merged commit f6d8788 into DefectDojo:dev Oct 22, 2021
@StefanFl StefanFl deleted the engagement_export branch October 22, 2021 11:41
@valentijnscholten valentijnscholten mentioned this pull request Nov 16, 2021
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@valentijnscholten valentijnscholten valentijnscholten approved these changes

@accesslint AccessLint accesslint approved these changes

@Maffooch Maffooch Maffooch approved these changes

Assignees
No one assigned
Labels
enhancement integration_tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@StefanFl @valentijnscholten @Maffooch