Allow undefined bind parameters (#38496)

DefinitelyTyped · Sep 25, 2019 · 1607336 · 1607336
1 parent 4822901
commit 1607336
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 2 deletions.
diff --git a/types/oracledb/index.d.ts b/types/oracledb/index.d.ts
@@ -578,7 +578,7 @@ declare namespace OracleDB {
      *
      * @see https://oracle.github.io/node-oracledb/doc/api.html#executebindParams
      */
-    type BindParameters = Record<string, BindParameter | string | number | Date | DBObject | Buffer | null> | BindParameter[] | any[];
+    type BindParameters = Record<string, BindParameter | string | number | Date | DBObject | Buffer | null | undefined> | BindParameter[] | any[];
 
     interface CloseConnectionOptions {
         /**

diff --git a/types/oracledb/oracledb-tests.ts b/types/oracledb/oracledb-tests.ts
@@ -143,7 +143,9 @@ const testResultSet = async (connection: oracledb.Connection): Promise<void> =>
             SELECT 2 FROM DUAL
             UNION
             SELECT 3 FROM DUAL`,
-        {},
+        {
+            test: undefined,
+        },
         {
             resultSet: true,
         },