Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

@types/oracledb - Allow undefined bind parameters #38496

Merged
merged 1 commit into from
Sep 25, 2019

Conversation

connorjayfitzgerald
Copy link
Contributor

Please fill in this template.

  • Use a meaningful title for the pull request. Include the name of the package modified.
  • Test the change in your own code. (Compile and run.)
  • Add or edit tests to reflect the change. (Run with npm test.)
  • Follow the advice from the readme.
  • Avoid common mistakes.
  • Run npm run lint package-name (or tsc if no tslint.json is present).

@typescript-bot typescript-bot added this to Check and Merge in Pull Request Status Board Sep 20, 2019
@typescript-bot typescript-bot added Awaiting reviewer feedback Author is Owner The author of this PR is a listed owner of the package. labels Sep 20, 2019
@typescript-bot
Copy link
Contributor

typescript-bot commented Sep 20, 2019

@connorjayfitzgerald Thank you for submitting this PR!

🔔 @Bigous - please review this PR in the next few days. Be sure to explicitly select Approve or Request Changes in the GitHub UI so I know what's going on.

If no reviewer appears after a week, a DefinitelyTyped maintainer will review the PR instead.

@typescript-bot
Copy link
Contributor

typescript-bot commented Sep 20, 2019

A definition owner has approved this PR ⭐️. A maintainer will merge this PR shortly. If it shouldn't be merged yet, please leave a comment saying so and we'll wait. Thank you for your contribution to DefinitelyTyped!

@typescript-bot
Copy link
Contributor

👋 Hi there! I’ve run some quick performance metrics against master and your PR. This is still an experiment, so don’t panic if I say something crazy! I’m still learning how to interpret these metrics.

Let’s review the numbers, shall we?

Comparison details 📊
master #38496 diff
Batch compilation
Memory usage (MiB) 65.5 65.8 +0.5%
Type count 8971 8971 0.0%
Assignability cache size 935 935 0.0%
Subtype cache size 57 57 0.0%
Identity cache size 6 6 0.0%
Language service
Samples taken 516 518 +0.4%
Identifiers in tests 516 518 +0.4%
getCompletionsAtPosition
    Mean duration (ms) 371.7 364.6 -1.9%
    Median duration (ms) 368.5 362.5 -1.6%
    Mean CV 12.9% 12.5% -3.3%
    Worst duration (ms) 472.2 472.6 +0.1%
    Worst identifier metadata poolTimeout
getQuickInfoAtPosition
    Mean duration (ms) 380.3 375.1 -1.4%
    Median duration (ms) 376.5 374.2 -0.6%
    Mean CV 13.6% 13.5% -0.8%
    Worst duration (ms) 475.8 459.0 -3.5%
    Worst identifier deepStrictEqual payloadTypeClass

It looks like nothing changed too much. I’m pretty lenient since I’m still an experiment, so take a look anyways and make sure nothing looks out of place.


If you have any questions or comments about me, you can ping @andrewbranch. Have a nice day!

@typescript-bot typescript-bot added Owner Approved A listed owner of this package signed off on the pull request. and removed Awaiting reviewer feedback labels Sep 20, 2019
@mrcrane mrcrane merged commit 1607336 into DefinitelyTyped:master Sep 25, 2019
Pull Request Status Board automation moved this from Check and Merge to Done Sep 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Author is Owner The author of this PR is a listed owner of the package. Owner Approved A listed owner of this package signed off on the pull request.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants