Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dependents are no longer tested in CI #22172

Closed
1 of 4 tasks
Flarna opened this issue Dec 13, 2017 · 6 comments
Closed
1 of 4 tasks

Dependents are no longer tested in CI #22172

Flarna opened this issue Dec 13, 2017 · 6 comments

Comments

@Flarna
Copy link
Contributor

Flarna commented Dec 13, 2017

  • I tried using the @types/xxxx package and had problems.
  • I tried using the latest stable version of tsc. https://www.npmjs.com/package/typescript
  • I have a question that is inappropriate for StackOverflow. (Please ask any appropriate questions there).
  • Mention the authors (see Definitions by: in index.d.ts) so they can respond.
    • Authors: @....

@andy-ms @RyanCavanaugh

A while ago all dependents have been tested also in CI. This was a pain for node as it resulted in timeouts and unrelated fails as it took too long to test all of them with all typescript version.
To my understanding this was improved via microsoft/types-publisher#398 to test dependents just with typescript@next.

Now it looks like that dependents are not tested at all anymore. is this intended?
See e.g. https://travis-ci.org/DefinitelyTyped/DefinitelyTyped/builds/316119572?utm_source=github_status&utm_medium=notification

@ghost
Copy link

ghost commented Dec 13, 2017

I was noticing some duplication of dependents yesterday. I'll take a look and see what the cause is. Thanks

@Flarna
Copy link
Contributor Author

Flarna commented Dec 18, 2017

@Flarna
Copy link
Contributor Author

Flarna commented Dec 18, 2017

Seems like testing dependencies is back - and also unrelated fails and timeouts. see https://travis-ci.org/DefinitelyTyped/DefinitelyTyped/builds/318182029?utm_source=github_status&utm_medium=notification

I ask myself why I reported this 😢

@ghost
Copy link

ghost commented Dec 18, 2017

We're up to 4007 typings now, so we're running into timeouts again even if testing only with typescript@next.
I had a script that looked for packages that provide their own types, so I'll resurrect that and see if we can get rid of some packages.

@Flarna
Copy link
Contributor Author

Flarna commented Dec 18, 2017

Is it somehow possible to split the test in to several jobs?
As far as I know the 50 minute timeout is per job not per build (see https://docs.travis-ci.com/user/customizing-the-build/#Build-Timeouts).
I could imagine something like one job testing dependencies A-K and a second on L-Z...

@ghost
Copy link

ghost commented Dec 20, 2017

That might be possible, but I'd like to look into improving performance as we also run all of the tests in a nightly script that is taking increasingly longer.

This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant