Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated webpack-dev-middleware to v2 #22267

Merged
merged 2 commits into from
Dec 29, 2017

Conversation

donaldpipowitch
Copy link
Contributor

@donaldpipowitch donaldpipowitch commented Dec 18, 2017

Please fill in this template.

  • Use a meaningful title for the pull request. Include the name of the package modified.
  • Test the change in your own code. (Compile and run.)
  • Follow the advice from the readme.
  • Avoid common mistakes.
  • Run npm run lint package-name (or tsc if no tslint.json is present).

Select one of these and delete the others:

If changing an existing definition:

cc @shellscape: Does this cover the changes correctly?

@shellscape
Copy link

@donaldpipowitch thanks for the ping 😄 I'm no TypeScript expert, but that appears correct. I'll also link to this in the README for folks who need this typedef.

@donaldpipowitch
Copy link
Contributor Author

Thank you for reviewing this! ♥️

@typescript-bot
Copy link
Contributor

After 5 days, no one has reviewed the PR 😞. A maintainer will be reviewing the PR in the next few days and will either merge it or request revisions. Thank you for your patience!

@typescript-bot typescript-bot added the Unmerged The author did not merge the PR when it was ready. label Dec 27, 2017
@paulvanbrenk paulvanbrenk merged commit 4303a1e into DefinitelyTyped:master Dec 29, 2017
@typescript-bot typescript-bot removed this from Merge: YSYL in Pull Request Triage Backlog Dec 29, 2017
@Flarna
Copy link
Contributor

Flarna commented Dec 29, 2017

This change broke karma-webpack and koa-webpack as they still use webpack-dev-middleware in v1 (see referenced PRs). Maybe v1 typings should be kept?

@shellscape
Copy link

koa-webpack will be updated to use wdm@2 soonish. the webpack team is testing leveraging that package and we've got some tests to run yet. If this package is versioned properly, it shouldn't have caused any havok (and I don't mean that to insinuate that it is not)

@paulvanbrenk
Copy link
Contributor

Didn't realize that these changes were in 2.x and the typing was still targeting 1.x, the correct way to handle would've been to have kept a v1 folder for the original typings. @donaldpipowitch can you make that change?

https://github.com/DefinitelyTyped/DefinitelyTyped#i-want-to-update-a-package-to-a-new-major-version

@Flarna
Copy link
Contributor

Flarna commented Dec 30, 2017

Regarding tests: There was an issue (#22172) causing that dependents were not tested which is fixed meanwhile.
Not sure if it is worth to keep a V1 version if dependents get updated soon anyway. The two fixes I proposed are simple and should be ok till update is done.

@donaldpipowitch
Copy link
Contributor Author

Oh snap. This slipped through... This should have been a new major version as announced in the title, but I forgot to update the file header. I'm sorry. Sadly I have no computer for some days. It would be great if this could be fixed by someone until I'm back again.

Sorry.

mhegazy pushed a commit that referenced this pull request Jan 3, 2018
* Fix type pollution

* Fix uncaught bugs of #22267
donaldpipowitch pushed a commit to donaldpipowitch/DefinitelyTyped that referenced this pull request Jan 4, 2018
@donaldpipowitch
Copy link
Contributor Author

First attempt to fix this PR: #22661.

mhegazy pushed a commit that referenced this pull request Jan 4, 2018
…rom #22267) (#22661)

* fix bugs from #22267

* try to fix "Older version 1 must have a path mapping for itself." error
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Unmerged The author did not merge the PR when it was ready.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants