Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

How can we make the issue tracker useful? #22632

Closed
RyanCavanaugh opened this issue Jan 3, 2018 · 9 comments
Closed

How can we make the issue tracker useful? #22632

RyanCavanaugh opened this issue Jan 3, 2018 · 9 comments
Assignees

Comments

@RyanCavanaugh
Copy link
Member

We're currently sitting at 1,809 open issues, a number which hasn't really ever been useful to think about. The issue tracker seems to have three kinds of bugs:

As far as I can tell, no one is taking specific action on anything here. The oldest bugs are years old.

Feedback we've heard from contributors is that it's hard to "listen" for discussion or bugs related to .d.ts files they've worked on. And as we can see from the issue tracker, people who don't know how to contribute fixes aren't really getting results from filing issues on the issue tracker.

What would a useful DefinitelyTyped issue tracker look like?

@RyanCavanaugh RyanCavanaugh self-assigned this Jan 3, 2018
@RyanCavanaugh
Copy link
Member Author

One idea: Have "digest" issues that people can subscribe to or comment on so that a) more discussion occurs in centralized locations and b) interested parties can subscribe to notifications to packages they like. Example mockup https://github.com/RyanCavanaugh/DefinitelyTyped/issues/1

@johnnyreilly
Copy link
Member

Worth a try - anything is better than the current quagmire!

@geovanisouza92
Copy link
Contributor

I'm available for issue tracking. Reach me if I can help.


Another thing that could help, is find a way to reestructure the types directory, because it has thousands of directories, and it's kinda annoying listing it on github or making contributions.

@mhegazy
Copy link
Contributor

mhegazy commented Jan 3, 2018

A common question/request is asking for adding a new package. i think for these, we should direct users to creating a new PR with a pointer to https://github.com/Microsoft/dts-gen.

@johnnyreilly
Copy link
Member

Excellent idea @mhegazy!

@geovanisouza92
Copy link
Contributor

Another idea: write messages on console, asking for people share new typings for missing modules, after installing some @types/*. Something like:

$ npm install @types/...
@types/... added bla bla...

Hey, consider sharing your typings for missing modules you encounter.

There's a way to create a "PR cli", enabling users to create typings directly from files? I don't know, suppose that I have a typings/xpto.d.ts in my project for a given xpto module that doesn't have typings published yet. So, I wish to dtd-gen --from-single-file typings/xpto.d.ts and that creates a PR on DT repo. What do you think?

@iRoachie
Copy link
Contributor

That’s a great idea, most of us if not all of us have a declarations.ts file in our src folder where we stub out definitions for libraries that don’t have official definitions. Would be great if we could take advantage of this.

@grant
Copy link
Contributor

grant commented Mar 16, 2018

I'd propose writing down some goals and taking small steps:

Goals

  • Reduce quantity of issues
  • Improve quality of issues
  • All new issues should be in great shape (not duplicate, well formatted)

Steps

  • Manually clean/close old issues
    • Merge issues that talk about the same definition. Use GitHub task lists instead of multiple issues.
  • Change the issue template to encourage searching existing issues and adding to those threads.
  • Create a repo that's meant for
    • Gathering definition requests
    • Creating new definitions that can then be promoted to this repo.
  • Get community help for managing these issues: I noticed the large number of pull request stacking up, do you want any help? #1834

@orta
Copy link
Collaborator

orta commented Jun 7, 2021

Hi thread, we're moving DefinitelyTyped to use GitHub Discussions for conversations the @types modules in DefinitelyTyped.

To help with the transition, we're closing all issues which haven't had activity in the last 6 months, which includes this issue. If you think closing this issue is a mistake, please pop into the TypeScript Community Discord and mention the issue in the definitely-typed channel.

@orta orta closed this as completed Jun 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

7 participants