Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

@types/hls.js - hls.audioTracks has incorrect typings (and lacks typings for subtitleTracks) #29311

Closed
4 tasks done
peboCodemill opened this issue Oct 1, 2018 · 2 comments
Closed
4 tasks done

Comments

@peboCodemill
Copy link

  • I tried using the @types/hls.js package and had problems.
  • I tried using the latest stable version of tsc. https://www.npmjs.com/package/typescript
  • I have a question that is inappropriate for StackOverflow. (Please ask any appropriate questions there).
  • Mention the authors (see Definitions by: in index.d.ts) so they can respond.

The method audioTracks: AudioTrack[]; returns data on the format seen below instead of the AudioTrack interface which is defined in lib.dom.

{
  audioCodec: string,
  autoselect: boolean,
  default: boolean,
  forced: boolean,
  groupId: string,
  id: number,
  lang: string,
  name: string,
  type: string,
  url: string
}

Also, the method subtitleTracks: any[]; is lacking correct typings. Would be nice if that got added as well! :)

{
  autoselect: boolean,
  default: boolean,
  forced: boolean,
  groupId: string,
  id: number,
  lang: string,
  name: string,
  type: string,
  url: string
}
@jgainfort
Copy link
Contributor

Ill try to get around to this shortly. In the meantime a PR would be great.

@orta
Copy link
Collaborator

orta commented Jun 7, 2021

Hi thread, we're moving DefinitelyTyped to use GitHub Discussions for conversations the @types modules in DefinitelyTyped.

To help with the transition, we're closing all issues which haven't had activity in the last 6 months, which includes this issue. If you think closing this issue is a mistake, please pop into the TypeScript Community Discord and mention the issue in the definitely-typed channel.

@orta orta closed this as completed Jun 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants