Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

@types/react-i18next "republish", not picking up dependent type updates #29408

Closed
4 tasks done
DevanB opened this issue Oct 3, 2018 · 1 comment · Fixed by #29945
Closed
4 tasks done

@types/react-i18next "republish", not picking up dependent type updates #29408

DevanB opened this issue Oct 3, 2018 · 1 comment · Fixed by #29945

Comments

@DevanB
Copy link
Contributor

DevanB commented Oct 3, 2018

If you know how to fix the issue, make a pull request instead.

Recently the @types/i18next package was updated that included a change that was correct for i18next.

The issue I'm here to report (and ask for guidance on how I can help) is that @types/react-i18next references the @types/i18next package, but was not updated with the new @types/i18next release.

I've verified this locally by navigating to node_modules/@types/react-i18next/node_modules/@types/i18next/index.d.ts and found that the update type is not present. I've also manually updated that index.d.ts and verified that the updated type corrects the issue.

A thread about this issue can be found at: #28892

I'm unsure of how to proceed to ask for a "rebuild/publish" of @types/react-i18next. Thanks! 😄

@chillitom
Copy link

also.. @types/react-i18next appears to be behind react-i18next with some interfaces not documented e.g. NamespacesConsumer

beheh added a commit to beheh/DefinitelyTyped that referenced this issue Oct 22, 2018
These have been released upstream as of react-i18next 8.1.0.
See i18next/react-i18next#557.

Closes DefinitelyTyped#29408
Closes DefinitelyTyped#29480
Closes DefinitelyTyped#29685
Closes DefinitelyTyped#29807
beheh added a commit to beheh/DefinitelyTyped that referenced this issue Oct 22, 2018
The upstream library now ships it's own as of react-i18next 8.1.0.
See i18next/react-i18next#557.

Closes DefinitelyTyped#29408
Closes DefinitelyTyped#29480
Closes DefinitelyTyped#29685
Closes DefinitelyTyped#29807
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants