Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

react-i18next definitions out of line with version 8+ of project #29480

Closed
3 tasks done
chillitom opened this issue Oct 5, 2018 · 5 comments · Fixed by #29945
Closed
3 tasks done

react-i18next definitions out of line with version 8+ of project #29480

chillitom opened this issue Oct 5, 2018 · 5 comments · Fixed by #29945

Comments

@chillitom
Copy link

Version 8 of react-i18next appears to have deprecated a few definitions and added some new interfaces.. e.g NamespacesConsumer link
and withNamespaces link
I'm relatively new to typescript and unsure of how to generate the definitions, I'd be happy to get involved if someone could give me some pointers.

@stefanKuijers
Copy link

We have the same problem. How big change to you guys think we would need to this package? Are they small definitions?

@DevanB
Copy link
Contributor

DevanB commented Oct 11, 2018

I've been investigating the same. I'm not well-versed in type packages creation yet, so struggling to handle with local module augmentation.

@jadbox
Copy link

jadbox commented Oct 16, 2018

This issue is particularly annoying since translate() has been renamed to withNamespaces, however the later is not typed yet. In the meantime I'm getting warnings from i19n to use the new convention. If react-i18next would be willing to move the definitions into their repo, I'd be more apt to help update the bindings.

@DevanB
Copy link
Contributor

DevanB commented Oct 16, 2018 via email

@Jessidhia
Copy link
Member

I started working on some type definitions locally, but I hit a snag about a week ago... and haven't picked it back up yet 😖

beheh added a commit to beheh/DefinitelyTyped that referenced this issue Oct 22, 2018
These have been released upstream as of react-i18next 8.1.0.
See i18next/react-i18next#557.

Closes DefinitelyTyped#29408
Closes DefinitelyTyped#29480
Closes DefinitelyTyped#29685
Closes DefinitelyTyped#29807
beheh added a commit to beheh/DefinitelyTyped that referenced this issue Oct 22, 2018
The upstream library now ships it's own as of react-i18next 8.1.0.
See i18next/react-i18next#557.

Closes DefinitelyTyped#29408
Closes DefinitelyTyped#29480
Closes DefinitelyTyped#29685
Closes DefinitelyTyped#29807
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants