New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
react-i18next definitions out of line with version 8+ of project #29480
Comments
We have the same problem. How big change to you guys think we would need to this package? Are they small definitions? |
I've been investigating the same. I'm not well-versed in type packages creation yet, so struggling to handle with local module augmentation. |
This issue is particularly annoying since translate() has been renamed to withNamespaces, however the later is not typed yet. In the meantime I'm getting warnings from i19n to use the new convention. If react-i18next would be willing to move the definitions into their repo, I'd be more apt to help update the bindings. |
I’ve got the withNamespaces typed out locally. But I can’t commit them back because a test doesn’t pass. The test doesn’t pass in the clean, current version of the typings too, though.
The react-i18n maintainer is very audibly against typed javascript and refuses to help or allow types in the code base. So I’d be surprised if you were to convince him. Until then, we will all have to band together to keep the types up to date.
… On Oct 16, 2018, at 16:29, Jonathan Dunlap ***@***.***> wrote:
This issue is particularly annoying since translate() has been renamed to withNamespaces, however the later is not typed yet. In the meantime I'm getting warnings from i19n to use the new convention. If react-i18next would be willing to move the definitions into their repo, I'd be more apt to help update the bindings.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub, or mute the thread.
|
I started working on some type definitions locally, but I hit a snag about a week ago... and haven't picked it back up yet 😖 |
These have been released upstream as of react-i18next 8.1.0. See i18next/react-i18next#557. Closes DefinitelyTyped#29408 Closes DefinitelyTyped#29480 Closes DefinitelyTyped#29685 Closes DefinitelyTyped#29807
The upstream library now ships it's own as of react-i18next 8.1.0. See i18next/react-i18next#557. Closes DefinitelyTyped#29408 Closes DefinitelyTyped#29480 Closes DefinitelyTyped#29685 Closes DefinitelyTyped#29807
Version 8 of react-i18next appears to have deprecated a few definitions and added some new interfaces.. e.g
NamespacesConsumer
linkand
withNamespaces
linkI'm relatively new to typescript and unsure of how to generate the definitions, I'd be happy to get involved if someone could give me some pointers.
@types/react-i18next
package and had problems.Definitions by:
inindex.d.ts
) so they can respond.The text was updated successfully, but these errors were encountered: