add props.children to StatelessComponent

[donaldpipowitch]

case 2. Improvement to existing type definition.

Handles props.children in StatelessComponent as in Component. Treats <Foo children={Bar} /> in the same way as <Foo><Bar /></Foo> with const Foo: StatelessComponent = (props) => <div>{props.children}</div>.

[paulvanbrenk]

Reading the comment on Component this seems like a workaround.

@RyanCavanaugh you can an opinion?

[donaldpipowitch]

Any update on this? :) // cc @RyanCavanaugh

[RyanCavanaugh]

I think this is an OK change for now. We'll probably be handling the question of children in TS 2.1 but this will be a good workaround in the meantime.

[donaldpipowitch]

Just as a reference for others: you're speaking about microsoft/TypeScript#8588, right?

[RyanCavanaugh]

That's right

[zhengbli]

@donaldpipowitch can you update the PR to resolve the merge conflict? Then it looks like it is ready to merge. Thanks!

[donaldpipowitch]

I'd like to do that after #11935 has been merged. It touches the same line, but is way more important. I don't want to introduce more barriers there.

[minestarks]

@donaldpipowitch Looks like #11935 has been merged. Do you plan to resolve the merge conflict? As this PR is getting stale, I plan to close it out soon if no changes. Thank you.

[donaldpipowitch]

@RyanCavanaug You said "I think this is an OK change for now. We'll probably be handling the question of children in TS 2.1 but this will be a good workaround in the meantime."

2.1 is around the corner, was this solved or is this workaround still useful?

[donaldpipowitch]

It looks like this was already added...? https://github.com/DefinitelyTyped/DefinitelyTyped/blob/types-2.0/react/index.d.ts#L204