-
Notifications
You must be signed in to change notification settings - Fork 29.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
vinyl: types for v2.0.0 #12368
vinyl: types for v2.0.0 #12368
Conversation
5e01385
to
1befc20
Compare
Seems like this build is hung up. https://travis-ci.org/DefinitelyTyped/DefinitelyTyped/builds/171968258 =============================================================================
DefinitelyTyped Test Runner 2.0.0
=============================================================================
Typescript version: 2.1.0-dev.20161031
Typings : 2247
TypeScript files : 2247
Total Memory : 60387 mb
Free Memory : 33676 mb
Cores : 32
Concurrent : 24
============================== Syntax checking ==============================
.............................................................................
.............................................................................
.............................................................................
.............................................................................
.............................................................................
.............................................................................
.............................................................................
.............................................................................
.............................................................................
.............................................................................
.............................................................................
.............................................................................
.............................................................................
.............................................................................
.............................................................................
.............................................................................
.............................................................................
................. |
@DenisCarriere It simply took 4822.323s for some reason. =) |
It's strange... maybe restart manually the travis-ci build. This PR is holding up all the other PRs using the types-2.0 branch. |
Look at the other PRs. Same situation there. E.g. #12365: 5364.871s. |
Switching to TS v2.0.6 doesn't help. Must be something else. |
gulp-util/index.d.ts to author (@jedmao). Could you review this PR? Checklist
|
LGTM. |
eae5d89
to
ec9eb4b
Compare
There are 2 known issues with this version of the definitions. You can find them in the tests (search for
TypeScript: known issue
). Namely:base
andpath
are odd in that their getters and setters are of different types. TypeScript doesn't support this, so a trade-off was needed.File
) doesn't work. Another trade-off. For the tricky type guards for thecontent
property to work, I used subclasses with an overloaded constructor signature. The type guarding magic works, but if you try to extendFile
you'll getBase constructors must all have the same return type.
This probably can be worked around, but so far I don't see how. Any ideas?Please fill in this template.
types-2.0
branch.If changing an existing definition: