Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vinyl: types for v2.0.0 #12368

Merged
merged 1 commit into from
Nov 29, 2016
Merged

Conversation

thorn0
Copy link
Contributor

@thorn0 thorn0 commented Oct 31, 2016

There are 2 known issues with this version of the definitions. You can find them in the tests (search for TypeScript: known issue). Namely:

  • The properties base and path are odd in that their getters and setters are of different types. TypeScript doesn't support this, so a trade-off was needed.
  • Inheritance (extending File) doesn't work. Another trade-off. For the tricky type guards for the content property to work, I used subclasses with an overloaded constructor signature. The type guarding magic works, but if you try to extend File you'll get Base constructors must all have the same return type. This probably can be worked around, but so far I don't see how. Any ideas?

Please fill in this template.

  • Prefer to make your PR against the types-2.0 branch.
  • The package does not provide its own types, and you can not add them.
  • Test the change in your own code.
  • Follow the advice from the readme.
  • Avoid common mistakes.

If changing an existing definition:

@dt-bot
Copy link
Member

dt-bot commented Oct 31, 2016

vinyl/index.d.ts

to authors (@vvakame @jedmao). Could you review this PR?
👍 or 👎?

Checklist

  • pass the Travis CI test?

@DenisCarriere
Copy link
Contributor

Seems like this build is hung up.

https://travis-ci.org/DefinitelyTyped/DefinitelyTyped/builds/171968258

=============================================================================
                    DefinitelyTyped Test Runner 2.0.0
=============================================================================
 Typescript version: 2.1.0-dev.20161031
 Typings           : 2247
 TypeScript files  : 2247
 Total Memory      : 60387 mb
 Free Memory       : 33676 mb
 Cores             : 32
 Concurrent        : 24
============================== Syntax checking ==============================
.............................................................................
.............................................................................
.............................................................................
.............................................................................
.............................................................................
.............................................................................
.............................................................................
.............................................................................
.............................................................................
.............................................................................
.............................................................................
.............................................................................
.............................................................................
.............................................................................
.............................................................................
.............................................................................
.............................................................................
.................

@thorn0
Copy link
Contributor Author

thorn0 commented Oct 31, 2016

@DenisCarriere It simply took 4822.323s for some reason. =)
I've reproduced this locally. Investigating.

@DenisCarriere
Copy link
Contributor

It's strange... maybe restart manually the travis-ci build. This PR is holding up all the other PRs using the types-2.0 branch.

@thorn0
Copy link
Contributor Author

thorn0 commented Oct 31, 2016

Look at the other PRs. Same situation there. E.g. #12365: 5364.871s.
May be something with the compiler.

@thorn0
Copy link
Contributor Author

thorn0 commented Oct 31, 2016

Switching to TS v2.0.6 doesn't help. Must be something else.

@vvakame
Copy link
Member

vvakame commented Nov 1, 2016

gulp-util/index.d.ts

to author (@jedmao). Could you review this PR?
👍 or 👎?

Checklist

  • pass the Travis CI test?

@vvakame
Copy link
Member

vvakame commented Nov 1, 2016

LGTM.

@alexeagle alexeagle force-pushed the types-2.0 branch 2 times, most recently from eae5d89 to ec9eb4b Compare November 23, 2016 21:00
@paulvanbrenk paulvanbrenk merged commit 639fda6 into DefinitelyTyped:types-2.0 Nov 29, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants