Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[types-2.0] d3-geo upgrade to version 1.4 #12753

Merged
1 commit merged into from
Nov 17, 2016
Merged

[types-2.0] d3-geo upgrade to version 1.4 #12753

1 commit merged into from
Nov 17, 2016

Conversation

tomwanzek
Copy link
Contributor

Please fill in this template.

  • Prefer to make your PR against the types-2.0 branch.
  • Test the change in your own code.
  • Follow the advice from the readme.
  • Avoid common mistakes.
  • Run npm run lint -- package-name if a tslint.json is present.

If adding a new definition:

  • The package does not provide its own types, and you can not add them.
  • If this is for an NPM package, match the name. If not, do not conflict with the name of an NPM package.
  • Run tsc without errors.
  • Include the required files and header. Base these on the README, not on an existing project.

If changing an existing definition:

  • Provide a URL to documentation or source code which provides context for the suggested changes: <https://github.com/d3/d3-geo/releases>
  • Increase the version number in the header if appropriate.

This PR fixes #12752

  • [Feature]: Add reflectX(...) and reflectY(...) to identity transform created with geoIdentity(). Tests included.

Note, that the other change referred to in the release note for d3-geo 1.4 is already conformed to.

* [Feature]: Add `reflectX(...)` and `reflectY(...)` to identity transform created with `geoIdentity()`.
@dt-bot
Copy link
Member

dt-bot commented Nov 17, 2016

d3-geo/index.d.ts

to authors (@Ledragon @tomwanzek @gustavderdrache @borisyankov). Could you review this PR?
👍 or 👎?

Checklist

  • pass the Travis CI test?

@tomwanzek
Copy link
Contributor Author

@andy-ms Wow, what a change in Travis testing! 🎆 !

@gustavderdrache
Copy link
Contributor

👍

@ghost ghost merged commit 2bafe6e into DefinitelyTyped:types-2.0 Nov 17, 2016
@tomwanzek tomwanzek deleted the d3-geo-upgrade-1.4 branch November 17, 2016 16:28
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants