Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add definitions for git-remote-origin-url #13845

Merged
1 commit merged into from
Jan 8, 2017

Conversation

janslow
Copy link
Contributor

@janslow janslow commented Jan 8, 2017

Please fill in this template.

  • Make your PR against the master branch.
  • Use a meaningful title for the pull request. Include the name of the package modified.
  • Test the change in your own code. (Compile and run.)
  • Follow the advice from the readme.
  • Avoid common mistakes.
  • Run tsc without errors.
  • Run npm run lint package-name if a tslint.json is present.

If adding a new definition:

  • The package does not provide its own types, and you can not add them. (see Add TypeScript definitions sindresorhus/git-remote-origin-url#6)
  • If this is for an NPM package, match the name. If not, do not conflict with the name of an NPM package.
  • Create it with npm run new-package package-name, not by basing it on an existing project.
  • tslint.json should be present, and tsconfig.json should have noImplicitAny, noImplicitThis, and strictNullChecks set to true.

@dt-bot
Copy link
Member

dt-bot commented Jan 8, 2017

git-remote-origin-url/index.d.ts

Checklist

@ghost
Copy link

ghost commented Jan 8, 2017

Thanks!

@ghost ghost merged commit d67e721 into DefinitelyTyped:master Jan 8, 2017
@janslow janslow deleted the git-remote-origin-url branch March 29, 2017 11:40
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants