New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Orientjs upgrade and update to support orientjs v3.0.0 features . #14425
Conversation
Create Orientjs v2.1.0 definition type
update for new feature of orientdb and orientjs
update version and upgrade features
orientjs/index.d.ts Checklist
|
All new feature of orientjs has declared in this definition update .
|
fix for query option params and correct if statement
- serverconfig fixed
- fix serverconfig
orientjs/orientjs.d.ts
Outdated
interface Migration { | ||
name: string; | ||
server: Server; | ||
Server: Server; | ||
db: Db; | ||
configure(config?: any): void; | ||
up(): Promise<any>; | ||
down(): Promise<any>; | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: can you remove this newline as well?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@aozgaa , i correct to case of server ; Server is invalid and server is valid .
add some fix for migration and properties compatibilities
add some fix for support property and migration
Hi @aozgaa , I fixed some issues on |
Can you resolve the merge conflicts? |
@aozgaa I have no any access to resolve it . |
@saeedtabrizi can you merge the conflict on your branch? Otherwise there is no way to merge it. Thanks! |
@zhengbli I have no any conflict in my local branch and i have no any access to resolve because i have no write access to resolve this conflicts . |
so if pull the latest |
@saeedtabrizi: are you able to update this PR as per @zhengbli's instructions? |
@zhengbli No , i have no detect any conflict in my code . |
I tried to manually merge this, but it looks like your changes are based on a very old version of the definition file. Please consider manually re-applying the changes on a clean copy of master and submitting a new PR. |
Please fill in this template.
master
branch.tsc
without errors.npm run lint package-name
if atslint.json
is present.Select one of these and delete the others:
If adding a new definition:
npm run new-package package-name
, not by basing it on an existing project.tslint.json
should be present, andtsconfig.json
should havenoImplicitAny
,noImplicitThis
, andstrictNullChecks
set totrue
.If changing an existing definition:
tslint.json
containing{ "extends": "../tslint.json" }
.If removing a declaration:
notNeededPackages.json
.