New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
react: Fix wrong type for e.currentTarget #14682
react: Fix wrong type for e.currentTarget #14682
Conversation
enzyme/index.d.ts to authors (@MarianPalkus @NoHomey @pelotom Cap3 (account can't be detected) jwbay (account can't be detected)). Could you review this PR? Checklist
fixed-data-table/index.d.ts to authors (@pepaar @stephenjelfs). Could you review this PR? Checklist
jsnox/index.d.ts to author (@stkb). Could you review this PR? Checklist
material-ui/index.d.ts to authors (@ngbrown @herrmanno). Could you review this PR? Checklist
radium/index.d.ts to authors (@alexgorbatchev @nupplaphil @asvetliakov @mihe). Could you review this PR? Checklist
react-addons-linked-state-mixin/index.d.ts can't parse definition header... react-addons-test-utils/index.d.ts can't parse definition header... react-addons-transition-group/index.d.ts can't parse definition header... react-bootstrap/index.d.ts to authors (@walkerburgin @vsiao @danilojrr @Batbold-Gansukh @octatone). Could you review this PR? Checklist
react-css-modules/index.d.ts to authors (@KostyaEsmukov @skirsdeda). Could you review this PR? Checklist
react-custom-scrollbars/index.d.ts to author (@David-LeBlanc-git). Could you review this PR? Checklist
react-datagrid/index.d.ts to author (@stephenjelfs). Could you review this PR? Checklist
react-fa/index.d.ts to authors (@flaub @patsissons @LKay). Could you review this PR? Checklist
react-holder/index.d.ts to author (@isman-usoh). Could you review this PR? Checklist
react-json-pretty/index.d.ts to author (@LKay). Could you review this PR? Checklist
react-leaflet/index.d.ts to author (@danzel). Could you review this PR? Checklist
react-mdl/index.d.ts to author (@bradzacher). Could you review this PR? Checklist
react-router/v2/lib/Link.d.ts can't parse definition header... react/index.d.ts to authors (@pspeter3 @vsiao @johnnyreilly @bbenezech @pzavolinsky AssureSign (account can't be detected) Microsoft (account can't be detected)). Could you review this PR? Checklist
|
efce421
to
7598796
Compare
Looks like we need to update this PR. |
a3a01d0
to
b1df7c5
Compare
Fixed..! (force update is used) |
Thanks, @ypresto |
Assuming you fix the build issue, LGTM. |
Closing, can you fix the CI build and the merge conflict. |
Many component type definitions uses React.Component subclass or
{}
forT
ofHTMLProps<T>
orHTMLAttributes<T>
, etc.But it is used for e.currentTarget passed to event handlers and it (
T
) should beHTMLElement
.(This PR contains #14618 because it will conflict on below line:)
master
branch.tsc
without errors.npm run lint package-name
if atslint.json
is present.If changing an existing definition:
tslint.json
containing{ "extends": "../tslint.json" }
.