Update d3-geo and d3 (#14756) #14831
Conversation
Update d3-geo version to 1.5.0 Updated d3 version to 4.6
|
d3-geo/index.d.ts to authors (@Ledragon @tomwanzek @gustavderdrache @borisyankov). Could you review this PR? Checklist
d3/index.d.ts to authors (@tomwanzek @gustavderdrache @borisyankov). Could you review this PR? Checklist
|
|
@Ledragon Thx will go over it before the end of the weekend! Take care, T |
d3-geo/index.d.ts
Outdated
| * | ||
| * This method observes any clipping performed by the projection. | ||
| * | ||
| * @param object GeoJSON object to measure. |
There was a problem hiding this comment.
Minor detail: For the other methods on GeoPath we started the @param description with An object..., We should keep it consistent, as the DatumObject does not have to be equivalent to the narrow definition of GeoJSON object.
There was a problem hiding this comment.
I actually changed the whole parameter comment for it to match the sentence structure of the other ones.
| @@ -936,6 +936,16 @@ export interface GeoPath<This, DatumObject extends GeoPermissibleObjects> { | |||
| centroid(object: DatumObject): [number, number]; | |||
There was a problem hiding this comment.
Can you please insert object after @param to read @param object An Object.... I must have overlooked the omission, when adding the JSDoc comments originally.
The same omission is also there for the area and bounds method. Thx.
Since we already have a PR open... 😄
There was a problem hiding this comment.
Yeah sure, done now :-)
|
👍 |
|
Thx to you. Let's hop this gets merged soon then |
|
Could this PR get merged, please? |
Regarding Issue #14756, this PR includes definition for the new path.measure method in d3-geo and the subsequent versions changes in d3 and d3-geo.
masterbranch.tscwithout errors.npm run lint package-nameif atslint.jsonis present. no tslinttslint.jsoncontaining{ "extends": "../tslint.json" }.cc @tomwanzek @gustavderdrache