Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add mutateIn and lookupIn to Couchbase Bucket definition. #17768

Closed

Conversation

JesseObrien
Copy link

I'm adding these to at least make them available to be used by typescript. There's more work to be done to add the proper return types including a LookUpInBuilder and MutateInBuilder but I don't have time to put these into play right now. I'll consider adding those later.

If changing an existing definition:

@dt-bot
Copy link
Member

dt-bot commented Jul 5, 2017

types/couchbase/index.d.ts

to author (@maouida). Could you review this PR?
👍 or 👎?

Checklist

  • pass the Travis CI test?

Copy link
Collaborator

@rbuckton rbuckton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The build failed due to an npm issue. After restarting the build there are errors that must be corrected.

* @param key The target document key.
* @param options The options object.
*/
mutateIn(key: string, options?: object): any;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use of the object keyword requires you to add a // TypeScript Version: 2.3 comment at the top of the file, per the readme

@rbuckton rbuckton added Revision needed This PR needs code changes before it can be merged. The Travis CI build failed labels Jul 7, 2017
@typescript-bot typescript-bot added the Abandoned This PR had no activity for a long time, and is considered abandoned label Jul 12, 2017
@typescript-bot
Copy link
Contributor

typescript-bot commented Jul 12, 2017

@JesseObrien Please fix the failures indicated in the Travis CI log.

@RyanCavanaugh
Copy link
Member

@JesseObrien Please fix the failures indicated in the Travis CI log.

@mhegazy
Copy link
Contributor

mhegazy commented Aug 8, 2017

Thanks for your contribution. This PR has failing CI tests and can not be merged in at the time being. For housekeeping purposes we are closing stale PRs. If you'd still like to merge this code in, please open a new PR that has been merged and rebased with the master branch.

@mhegazy mhegazy closed this Aug 8, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Abandoned This PR had no activity for a long time, and is considered abandoned Revision needed This PR needs code changes before it can be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants