- Added urlrouter.d.ts #1820
Closed
- Added urlrouter.d.ts #1820
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jQUery Validation does not send arguments but an array of the argument already built. By using the ... syntax of TypeScript, we get an array with one item that has the array sent by jQuery validation. I think the definition should use an array instead of arguments syntax.
…d updated definitions to pass
This version is more complete and includes inline JSDoc comments for most types/functions/properties.
node-ffi: fix Function overrides
addMethod params arguments vs array syntax
Add definition of jquery.placeholder
Added missing functions to d3 EnterSelection interface
Fixed d3 definitions for d3.geom.voronoi
Socket.io lifting :)
|
@soywiz Thanks for the contribution. Please, could you make these small changes in your file?
Thank you! |
More updates for the latest version.
Adds missing method CORS on restify type definition
fix the return type of google.maps.Polygon.getPaths
Fix AngularJS $q.when definition
Some jasmine.d.ts fixes
Update "smoothie" declarations with version from project itself.
|
It seems I did it wrong. I have deleted and recreated the repository and a branch instead of master. Also I have added tests and readme as you said. I'm going to create another pull request. Thanks. |
This was referenced Feb 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.