Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[@types/react-content-loader] introduce primaryOpacity and secondaryOpacity props + bump version to 3.1 #25669

Merged
merged 6 commits into from May 14, 2018
Merged

[@types/react-content-loader] introduce primaryOpacity and secondaryOpacity props + bump version to 3.1 #25669

merged 6 commits into from May 14, 2018

Conversation

samwalshnz
Copy link
Contributor

@samwalshnz samwalshnz mentioned this pull request May 10, 2018
Merged
@samwalshnz samwalshnz changed the title [react-content-loader] Introduce primaryOpacity and secondaryOpacity props + bump version to 3.1.2 [@types/react-content-loader] - introduce primaryOpacity and secondaryOpacity props + bump version to 3.1.2 May 10, 2018
@samwalshnz samwalshnz changed the title [@types/react-content-loader] - introduce primaryOpacity and secondaryOpacity props + bump version to 3.1.2 [@types/react-content-loader] introduce primaryOpacity and secondaryOpacity props + bump version to 3.1 May 10, 2018
@typescript-bot typescript-bot added this to Waiting for Reviewers in Pull Request Status Board May 10, 2018
@typescript-bot
Copy link
Contributor

typescript-bot commented May 10, 2018 •
edited

@samwalshnz Thank you for submitting this PR!

🔔 @alaatm - please review this PR in the next few days. Be sure to explicitly select Approve or Request Changes in the GitHub UI so I know what's going on.

If no reviewer appears after a week, a DefinitelyTyped maintainer will review the PR instead.

hasantayyar
hasantayyar reviewed May 11, 2018
View reviewed changes
types/react-content-loader/index.d.ts Outdated

export interface ContentLoaderProps {
style?: React.CSSProperties;
type?: 'facebook' | 'instagram' | 'list' | 'bullet-list' | 'code';
type?: "facebook" | "instagram" | "list" | "bullet-list" | "code";
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why double quotes?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apologies - it looks like my code formatter has taken over

alaatm
alaatm suggested changes May 12, 2018
View reviewed changes
Copy link
Contributor

@alaatm alaatm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you use single quotes please since this repo uses single quotes.

@typescript-bot typescript-bot moved this from Waiting for Reviewers to Needs Author Attention in Pull Request Status Board May 12, 2018
@typescript-bot typescript-bot added Revision needed This PR needs code changes before it can be merged. and removed Awaiting reviewer feedback labels May 12, 2018
@typescript-bot
Copy link
Contributor

@samwalshnz One or more reviewers has requested changes. Please address their comments. I'll be back once they sign off or you've pushed new commits or comments. Thank you!

@typescript-bot typescript-bot added the Revision needed This PR needs code changes before it can be merged. label May 12, 2018
@samwalshnz
Copy link
Contributor Author

@alaatm I have fixed up those code formatting changes

@typescript-bot typescript-bot added the Revision needed This PR needs code changes before it can be merged. label May 13, 2018
@typescript-bot
Copy link
Contributor

🔔 @alaatm - Thanks for your review of this PR! Can you please look at the new code and update your review status if appropriate?

@typescript-bot typescript-bot added the Revision needed This PR needs code changes before it can be merged. label May 13, 2018
@typescript-bot typescript-bot moved this from Needs Author Attention to Check and Merge in Pull Request Status Board May 14, 2018
@typescript-bot typescript-bot added Owner Approved A listed owner of this package signed off on the pull request. Merge:Express labels May 14, 2018
@typescript-bot
Copy link
Contributor

A definition owner has approved this PR ⭐️. A maintainer will merge this PR shortly. If it shouldn't be merged yet, please leave a comment saying so and we'll wait. Thank you for your contribution to DefinitelyTyped!

@rbuckton rbuckton merged commit b6c31c0 into DefinitelyTyped:master May 14, 2018
@typescript-bot typescript-bot removed this from Check and Merge in Pull Request Status Board May 14, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hasantayyar hasantayyar hasantayyar left review comments

@alaatm alaatm alaatm approved these changes

@rbuckton rbuckton rbuckton approved these changes

Assignees
No one assigned
Labels
Owner Approved A listed owner of this package signed off on the pull request. Revision needed This PR needs code changes before it can be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@samwalshnz @typescript-bot @hasantayyar @alaatm @rbuckton