Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix complain on map function that T is any #26600

Closed
wants to merge 1 commit into from
Closed

Fix complain on map function that T is any #26600

wants to merge 1 commit into from

Conversation

NattapongSiri
Copy link
Contributor

Please fill in this template.

  • Use a meaningful title for the pull request. Include the name of the package modified.
  • Test the change in your own code. (Compile and run.)
  • Add or edit tests to reflect the change. (Run with npm test.)
  • Follow the advice from the readme.
  • Avoid common mistakes.
  • Run npm run lint package-name (or tsc if no tslint.json is present).

Select one of these and delete the others:
@CaselIT
Possible fix for issue #26599

@typescript-bot typescript-bot added this to Waiting for Reviewers in Pull Request Status Board Jun 16, 2018
@typescript-bot typescript-bot added Popular package This PR affects a popular package (as counted by NPM download counts). Awaiting reviewer feedback labels Jun 16, 2018
@typescript-bot
Copy link
Contributor

typescript-bot commented Jun 16, 2018

@NattapongSiri Thank you for submitting this PR!

🔔 @CaselIT @alanmarcell @kikar @bitjson @Dante-101 @mcortesi @EnricoPicci @AJCStriker @julien-c @daprahamian - please review this PR in the next few days. Be sure to explicitly select Approve or Request Changes in the GitHub UI so I know what's going on.

If no reviewer appears after a week, a DefinitelyTyped maintainer will review the PR instead.

@CaselIT
Copy link
Contributor

CaselIT commented Jun 16, 2018

This is a duplicate of #26594

@typescript-bot typescript-bot moved this from Waiting for Reviewers to Needs Author Attention in Pull Request Status Board Jun 18, 2018
@typescript-bot typescript-bot added the Has Merge Conflict This PR can't be merged because it has a merge conflict. The author needs to update it. label Jun 18, 2018
@typescript-bot
Copy link
Contributor

@NattapongSiri Unfortunately, this pull request currently has a merge conflict 😥. Please update your PR branch to be up-to-date with respect to master. Have a nice day!

@typescript-bot typescript-bot added Popular package This PR affects a popular package (as counted by NPM download counts). and removed Popular package This PR affects a popular package (as counted by NPM download counts). labels Jun 27, 2018
@mhegazy
Copy link
Contributor

mhegazy commented Jul 2, 2018

Thanks for your contribution. This PR has merge conflicts and can not be merged in at the time being. For housekeeping purposes we are closing stale PRs. If you'd still like to merge this code in, please open a new PR that has been merged and rebased with the master branch.

@mhegazy mhegazy closed this Jul 2, 2018
@typescript-bot typescript-bot removed this from Needs Author Attention in Pull Request Status Board Jul 2, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Has Merge Conflict This PR can't be merged because it has a merge conflict. The author needs to update it. Popular package This PR affects a popular package (as counted by NPM download counts).
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants