Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed mongodb typings implicit any error #26638

Merged
merged 2 commits into from
Jun 18, 2018
Merged

Fixed mongodb typings implicit any error #26638

merged 2 commits into from
Jun 18, 2018

Conversation

vanwalj
Copy link
Contributor

@vanwalj vanwalj commented Jun 18, 2018

Please fill in this template.

  • Use a meaningful title for the pull request. Include the name of the package modified.
  • Test the change in your own code. (Compile and run.)
  • Add or edit tests to reflect the change. (Run with npm test.)
  • Follow the advice from the readme.
  • Avoid common mistakes.
  • Run npm run lint package-name (or tsc if no tslint.json is present).

I fixed a typing typo (I guess) where the argument name was missing and enabled the noImplicitAny option so it won't happen again !

@typescript-bot typescript-bot added this to Waiting for Reviewers in Pull Request Status Board Jun 18, 2018
@typescript-bot typescript-bot added Popular package This PR affects a popular package (as counted by NPM download counts). Awaiting reviewer feedback labels Jun 18, 2018
@typescript-bot
Copy link
Contributor

typescript-bot commented Jun 18, 2018

@vanwalj Thank you for submitting this PR!

🔔 @CaselIT @alanmarcell @kikar @bitjson @Dante-101 @mcortesi @EnricoPicci @AJCStriker @julien-c @daprahamian - please review this PR in the next few days. Be sure to explicitly select Approve or Request Changes in the GitHub UI so I know what's going on.

If no reviewer appears after a week, a DefinitelyTyped maintainer will review the PR instead.

@CaselIT
Copy link
Contributor

CaselIT commented Jun 18, 2018

This a duplicate of #26594
@vanwalj Apart from the change in index.d.ts that is duplicate, I think it would be better if we enable the flag noImplicitAny

@vanwalj
Copy link
Contributor Author

vanwalj commented Jun 18, 2018

You are right, I didn’t saw that before.
What should I do ? :)

@typescript-bot typescript-bot moved this from Waiting for Reviewers to Needs Author Attention in Pull Request Status Board Jun 18, 2018
@typescript-bot typescript-bot added the Has Merge Conflict This PR can't be merged because it has a merge conflict. The author needs to update it. label Jun 18, 2018
@typescript-bot
Copy link
Contributor

@vanwalj Unfortunately, this pull request currently has a merge conflict 😥. Please update your PR branch to be up-to-date with respect to master. Have a nice day!

@typescript-bot typescript-bot moved this from Needs Author Attention to Waiting for Reviewers in Pull Request Status Board Jun 18, 2018
@typescript-bot typescript-bot removed the Has Merge Conflict This PR can't be merged because it has a merge conflict. The author needs to update it. label Jun 18, 2018
@typescript-bot typescript-bot moved this from Waiting for Reviewers to Check and Merge in Pull Request Status Board Jun 18, 2018
@typescript-bot typescript-bot added Owner Approved A listed owner of this package signed off on the pull request. Merge:Express and removed Awaiting reviewer feedback labels Jun 18, 2018
@typescript-bot
Copy link
Contributor

A definition owner has approved this PR ⭐️. A maintainer will merge this PR shortly. If it shouldn't be merged yet, please leave a comment saying so and we'll wait. Thank you for your contribution to DefinitelyTyped!

@sandersn sandersn merged commit f0526da into DefinitelyTyped:master Jun 18, 2018
@typescript-bot typescript-bot removed this from Check and Merge in Pull Request Status Board Jun 18, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Owner Approved A listed owner of this package signed off on the pull request. Popular package This PR affects a popular package (as counted by NPM download counts).
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants