Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[react-native-vector-icons] Exposed Icon methods #27444

Conversation

SudoPlz
Copy link
Contributor

@SudoPlz SudoPlz commented Jul 20, 2018

- Exposes methods implemented in: https://github.com/oblador/react-native-vector-icons/pull/762

Please fill in this template.

  • ✅ Use a meaningful title for the pull request. Include the name of the package modified.
  • ✅ Test the change in your own code. (Compile and run.)
  • ✅ Add or edit tests to reflect the change. (Run with npm test.)
  • ✅ Follow the advice from the readme.
  • ✅ Avoid common mistakes.
  • ✅ Run npm run lint package-name (or tsc if no tslint.json is present).

Select one of these and delete the others:

If changing an existing definition:

@typescript-bot
Copy link
Contributor

typescript-bot commented Jul 20, 2018

@SudoPlz Thank you for submitting this PR!

🔔 @iRoachie @timwangdev - please review this PR in the next few days. Be sure to explicitly select Approve or Request Changes in the GitHub UI so I know what's going on.

If no reviewer appears after a week, a DefinitelyTyped maintainer will review the PR instead.

Copy link
Contributor

@kyler-hyuna kyler-hyuna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

--

Copy link
Contributor

@iRoachie iRoachie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@SudoPlz I can't merge this until that PRs been accepted. Just ping me and let me know. You would also need to bump the version when it's released

@SudoPlz
Copy link
Contributor Author

SudoPlz commented Jul 20, 2018

Ok, I'll ping you when the PR get's merged @iRoachie

Thanks for taking a look

@typescript-bot typescript-bot moved this from Waiting for Reviewers to Needs Author Attention in Pull Request Status Board Jul 20, 2018
@typescript-bot typescript-bot added Revision needed This PR needs code changes before it can be merged. and removed Awaiting reviewer feedback labels Jul 20, 2018
@typescript-bot
Copy link
Contributor

@SudoPlz One or more reviewers has requested changes. Please address their comments. I'll be back once they sign off or you've pushed new commits or comments. Thank you!

@typescript-bot typescript-bot added the Revision needed This PR needs code changes before it can be merged. label Jul 20, 2018
@SudoPlz
Copy link
Contributor Author

SudoPlz commented Jul 24, 2018

Ok, the PR is merged @iRoachie can you merge now?

@iRoachie
Copy link
Contributor

Waiting until he cuts a version.

@typescript-bot typescript-bot added the Revision needed This PR needs code changes before it can be merged. label Jul 24, 2018
@typescript-bot
Copy link
Contributor

@SudoPlz I haven't seen anything from you in a while and this PR currently has problems that prevent it from being merged. The PR will be closed tomorrow if there aren't new commits to fix the issues.

@typescript-bot typescript-bot added the Revision needed This PR needs code changes before it can be merged. label Jul 26, 2018
@SudoPlz
Copy link
Contributor Author

SudoPlz commented Jul 26, 2018

pff..

@iRoachie
Copy link
Contributor

Lol i'll update just so the bot doesn't close

@SudoPlz
Copy link
Contributor Author

SudoPlz commented Jul 26, 2018

Aah, cool, thanks @iRoachie

@typescript-bot typescript-bot added Owner Approved A listed owner of this package signed off on the pull request. Revision needed This PR needs code changes before it can be merged. labels Jul 26, 2018
@typescript-bot typescript-bot moved this from Needs Author Attention to Check and Merge in Pull Request Status Board Jul 26, 2018
@typescript-bot typescript-bot added Other Approved This PR was reviewed and signed-off by a community member. Merge:Express labels Jul 26, 2018
@typescript-bot
Copy link
Contributor

A definition owner has approved this PR ⭐️. A maintainer will merge this PR shortly. If it shouldn't be merged yet, please leave a comment saying so and we'll wait. Thank you for your contribution to DefinitelyTyped!

@iRoachie
Copy link
Contributor

Don't merge: pending version release of react-native-vector-icons

@oblador
Copy link

oblador commented Jul 28, 2018

Just released as 5.0.0 👍

Copy link
Contributor

@iRoachie iRoachie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@typescript-bot typescript-bot moved this from Check and Merge to Needs Author Attention in Pull Request Status Board Jul 28, 2018
@typescript-bot typescript-bot added Revision needed This PR needs code changes before it can be merged. and removed Owner Approved A listed owner of this package signed off on the pull request. Merge:Express labels Jul 28, 2018
@typescript-bot typescript-bot added Abandoned This PR had no activity for a long time, and is considered abandoned Revision needed This PR needs code changes before it can be merged. labels Aug 4, 2018
@typescript-bot
Copy link
Contributor

@SudoPlz To keep things tidy, we have to close PRs that aren't mergeable but don't have activity from their author. No worries, though - please open a new PR if you'd like to continue with this change. Thank you!

@typescript-bot typescript-bot removed this from Needs Author Attention in Pull Request Status Board Aug 4, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Abandoned This PR had no activity for a long time, and is considered abandoned Other Approved This PR was reviewed and signed-off by a community member. Revision needed This PR needs code changes before it can be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants