Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exposes advanced methods in Icon component. #762

Merged
merged 4 commits into from
Jul 24, 2018
Merged

Conversation

SudoPlz
Copy link
Contributor

@SudoPlz SudoPlz commented Jul 3, 2018

Hi,

because of an advanced use-case in our app, we really need to be able to get glyphs manually, and pass them to a Text component on our own.

This PR exposes the raw glyph map.

@oblador
Copy link
Owner

oblador commented Jul 3, 2018

Thanks! What's the use case?

@SudoPlz
Copy link
Contributor Author

SudoPlz commented Jul 3, 2018

I'm using react-native and I'm implementing a concept that's called synchronous rendering

Here's more.

Here's a project that uses that : https://github.com/SudoPlz/react-native-synchronous-list

There are certain limitations synchronous rendering enforces, one of which is, there can't be any calculations that take place upon rendering, everything must be declarative (no if clauses - nothing), so I need to pass the text and the font family manually via props.

@SudoPlz
Copy link
Contributor Author

SudoPlz commented Jul 6, 2018

@oblador any news with that?

The addition is pretty minor, and it's not messing with existing functionality, it just adds something, can you merge?

@oblador
Copy link
Owner

oblador commented Jul 17, 2018

The sync rendering looks like cool stuff! Think we should document these methods it in the README maybe? Also include it in the TypeScript typings.

@SudoPlz
Copy link
Contributor Author

SudoPlz commented Jul 17, 2018

Sure, I can create another commit, but right now I'm in Amsterdam. I'll do that as soon as I get home in a couple of days.

SudoPlz added a commit to SudoPlz/DefinitelyTyped that referenced this pull request Jul 20, 2018
@SudoPlz SudoPlz changed the title Exposes the glyph map with Icon.getRawGlyphMap Exposes advanced methods in Icon component. Jul 20, 2018
@SudoPlz
Copy link
Contributor Author

SudoPlz commented Jul 20, 2018

I'm back.

Modified README.md and I edited the types:

DefinitelyTyped/DefinitelyTyped#27444

@SudoPlz
Copy link
Contributor Author

SudoPlz commented Jul 20, 2018

@oblador The typings PR needs this PR to be accepted before it get's accepted.
Are we also going to bump the version? Looks like it's needed.

@oblador oblador merged commit 5190490 into oblador:master Jul 24, 2018
@SudoPlz
Copy link
Contributor Author

SudoPlz commented Jul 24, 2018

Awesome, thanks @oblador, can you also add a new version so that DefinitelyTyped/DefinitelyTyped#27444 can be merged too?

@SudoPlz
Copy link
Contributor Author

SudoPlz commented Jul 26, 2018

@oblador this PR above is going to get closed tomorrow, can you possibly publish a minor version in order to merge the typescript PR?

@oblador
Copy link
Owner

oblador commented Jul 27, 2018

Hi, I'm waiting on some FontAwesome 5 fixes before I'm comfortable with releasing a new version. Seems like the auto closing bot has been fixed too. I'll ping the FA5 author to see if we can get this out soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants