New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add types for experimetal worker_threads module #31177
Add types for experimetal worker_threads module #31177
Conversation
@BendingBender Thank you for submitting this PR! 🔔 @microsoft @DefinitelyTyped @jkomyno @a-tarasyuk @alvis @r3nya @BrunoScheufler @smac89 @tellnes @DeividasBakanas @eyqs @Flarna @Hannes-Magnusson-CK @KSXGitHub @hoo29 @kjin @ajafff @islishude @mwiktorczyk @matthieusieben @mohsen1 @n-e @octo-sniffle @parambirs @eps1lon @SimonSchick @ThomasdenH @WilcoBakker @wwwy3y3 @ZaneHannanAU @jeremiergz @samuela - please review this PR in the next few days. Be sure to explicitly select If no reviewer appears after a week, a DefinitelyTyped maintainer will review the PR instead. |
@BendingBender The Travis CI build failed! Please review the logs for more information. Once you've pushed the fixes, the build will automatically re-run. Thanks! |
d7a0514
to
509f5ef
Compare
@BendingBender The Travis CI build failed! Please review the logs for more information. Once you've pushed the fixes, the build will automatically re-run. Thanks! |
509f5ef
to
9ebfec0
Compare
@BendingBender The Travis CI build failed! Please review the logs for more information. Once you've pushed the fixes, the build will automatically re-run. Thanks! |
Probably shouldn't use console, but idk. Looks good to me otherwise. We REALLY need to deprecate those broken packages. |
@ZaneHannanAU the broken package is a really strange one, it only breaks on typescript@next. This looks like a bug in the compiler, not in the package definitions. |
Well, unist-util-is is just two days old so maybe a bit early to deprecate it 😁. |
… I think, at this point, we should have the CI check every package and not just what has been definitely effected. But then that'll take forever. … ugh, there're gonna be too many damn edge cases. |
5dae445
to
4cd8491
Compare
@BendingBender The Travis CI build failed! Please review the logs for more information. Once you've pushed the fixes, the build will automatically re-run. Thanks! |
Changed my mind - I think the test is wrong. I'll follow up on the other PR (and try to determine why the CI didn't catch this). |
@BendingBender uninst-util-is should be fixed by #31257. You could try to retrigger CI, hopefully it's green now. |
4cd8491
to
354829f
Compare
A definition owner has approved this PR ⭐️. A maintainer will merge this PR shortly. If it shouldn't be merged yet, please leave a comment saying so and we'll wait. Thank you for your contribution to DefinitelyTyped! |
Please fill in this template.
npm test
.)npm run lint package-name
(ortsc
if notslint.json
is present).If changing an existing definition:
tslint.json
containing{ "extends": "dtslint/dt.json" }
.