-
Notifications
You must be signed in to change notification settings - Fork 30.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix type of Redux Form event handlers. #31607
Fix type of Redux Form event handlers. #31607
Conversation
@davidgomes Thank you for submitting this PR! 🔔 @CarsonF @aikoven @LKay @bancek @alsiola @tehbi4 @huwmartin @ethanresnick @Reggino @maddijoyce @smifun - please review this PR in the next few days. Be sure to explicitly select If no reviewer appears after a week, a DefinitelyTyped maintainer will review the PR instead. |
After 5 days, no one has reviewed the PR 😞. A maintainer will be reviewing the PR in the next few days and will either merge it or request revisions. Thank you for your patience! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@davidgomes Thanks for fixing type definitions.
I appreciate if you could take a look at my suggestions
… with Redux Form naming. Co-Authored-By: davidgomes <davidrafagomes@gmail.com>
…handlers in redux-form. https://redux-form.com/7.4.2/docs/api/field.md/#-code-onblur-event-newvalue-previousvalue-name-gt-void-code-optional- https://redux-form.com/7.4.2/docs/api/field.md/#-code-ondragstart-event-name-gt-void-code-optional- Co-Authored-By: davidgomes <davidrafagomes@gmail.com>
@mshaaban088 great suggestions, I edited the PR's description to account for these changes. |
@davidgomes Awesome! |
Done! |
Thanks @davidgomes |
This PR updates the event handlers for the
onBlur
,onDragStart
,onChange
,onDrop
andonFocus
to support the optionalname
(field name) parameter.I ran
npm run test
andnpm run lint redux-form
. Both returned no errors.https://redux-form.com/7.4.2/docs/api/field.md/#-code-onblur-event-newvalue-previousvalue-name-gt-void-code-optional-
Here above is the API definition for the functions that I changed, which were missing the last argument.