New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix type of Redux Form event handlers. #31607

Merged
merged 4 commits into from Dec 31, 2018

Conversation

Projects
None yet
4 participants
@davidgomes
Copy link
Contributor

davidgomes commented Dec 22, 2018

This PR updates the event handlers for the onBlur, onDragStart, onChange, onDrop and onFocus to support the optional name (field name) parameter.

I ran npm run test and npm run lint redux-form. Both returned no errors.

https://redux-form.com/7.4.2/docs/api/field.md/#-code-onblur-event-newvalue-previousvalue-name-gt-void-code-optional-

Here above is the API definition for the functions that I changed, which were missing the last argument.

@typescript-bot

This comment has been minimized.

Copy link

typescript-bot commented Dec 22, 2018

@davidgomes Thank you for submitting this PR!

🔔 @CarsonF @aikoven @LKay @bancek @alsiola @tehbi4 @huwmartin @ethanresnick @Reggino @maddijoyce @smifun - please review this PR in the next few days. Be sure to explicitly select Approve or Request Changes in the GitHub UI so I know what's going on.

If no reviewer appears after a week, a DefinitelyTyped maintainer will review the PR instead.

@typescript-bot typescript-bot moved this from Waiting for Reviewers to Review in Pull Request Status Board Dec 27, 2018

@typescript-bot

This comment has been minimized.

Copy link

typescript-bot commented Dec 27, 2018

After 5 days, no one has reviewed the PR 😞. A maintainer will be reviewing the PR in the next few days and will either merge it or request revisions. Thank you for your patience!

@mshaaban088
Copy link
Contributor

mshaaban088 left a comment

@davidgomes Thanks for fixing type definitions.
I appreciate if you could take a look at my suggestions

Show resolved Hide resolved types/redux-form/lib/Field.d.ts Outdated
Show resolved Hide resolved types/redux-form/lib/Field.d.ts Outdated

mshaaban088 and others added some commits Dec 31, 2018

Rename `fieldName` to `name` to keep flow type definitions consistent…
… with Redux Form naming.

Co-Authored-By: davidgomes <davidrafagomes@gmail.com>
@davidgomes

This comment has been minimized.

Copy link
Contributor

davidgomes commented Dec 31, 2018

@mshaaban088 great suggestions, I edited the PR's description to account for these changes.

@mshaaban088

This comment has been minimized.

Copy link
Contributor

mshaaban088 commented Dec 31, 2018

@davidgomes Awesome!
One minor suggestion, as onDrop is implicitly affected, it makes sense to add it too to the description ;)

@davidgomes

This comment has been minimized.

Copy link
Contributor

davidgomes commented Dec 31, 2018

@davidgomes Awesome!
One minor suggestion, as onDrop is implicitly affected, it makes sense to add it too to the description ;)

Done!

@mshaaban088

This comment has been minimized.

Copy link
Contributor

mshaaban088 commented Dec 31, 2018

Thanks @davidgomes

@typescript-bot typescript-bot moved this from Review to Waiting for Reviewers in Pull Request Status Board Dec 31, 2018

@sheetalkamat sheetalkamat merged commit 6b9f1df into DefinitelyTyped:master Dec 31, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@typescript-bot typescript-bot removed this from Waiting for Reviewers in Pull Request Status Board Dec 31, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment